Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report size of app bundles on PRs (#28019) #28041

Closed
wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Feb 12, 2020

Summary:
Report size of app bundles on PRs. See React Native Benchmark Suite for further discussion.

Changelog

[Internal] [Added] - Report size of app bundles on PRs
Pull Request resolved: #28019

Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully.

Differential Revision: D19859187

Pulled By: hramos

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team fb-exported labels Feb 12, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D19859187

@pull-bot
Copy link

pull-bot commented Feb 12, 2020

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 667ccfd

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Feb 12, 2020
@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3274752 bytes
RNTester (Android/hermes/armeabi-v7a): 3115008 bytes
RNTester (Android/hermes/x86): 3440640 bytes
RNTester (Android/hermes/x86_64): 3405824 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4265984 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

Summary:
Pull Request resolved: facebook#28041

Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion.

## Changelog

[Internal] [Added] - Report size of app bundles on PRs
Pull Request resolved: facebook#28019

Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully.

Reviewed By: cpojer

Differential Revision: D19859187

Pulled By: hramos

fbshipit-source-id: 0eb510287ba2001895d66d038fc1e7b8a722d9a8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D19859187

@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3276800 bytes
RNTester (Android/hermes/armeabi-v7a): 3117056 bytes
RNTester (Android/hermes/x86): 3442688 bytes
RNTester (Android/hermes/x86_64): 3407872 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4268032 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4646912 bytes

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @tido64 in 1b56292.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 13, 2020
@vonovak
Copy link
Contributor

vonovak commented Feb 19, 2020

@hramos this bot continually adds comments to PRs as new commits are being added (at least in #28009). I think it'd be it nicer if it instead edited the original comment, as the current behavior creates unnecessary noise (moreover, it adds 2 comments, not just 1).

@tido64
Copy link
Collaborator

tido64 commented Feb 25, 2020

@vonovak: I have a PR that will make it less spammy here: #28169.

osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
Pull Request resolved: facebook#28041

Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion.

## Changelog

[Internal] [Added] - Report size of app bundles on PRs
Pull Request resolved: facebook#28019

Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully.

Reviewed By: cpojer

Differential Revision: D19859187

Pulled By: hramos

fbshipit-source-id: 3920dc60e6fd073928388e6ae52fc2ba1bc745ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants