Improvements to app bundle size reports #28169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
|
RNTester.app (iOS): 10657792 bytes |
|
|
RNTester.app (iOS): 10657792 bytes |
- Generate table for APK sizes - Replace existing comment if possible
tido64
force-pushed
the
tido/size-bot-improvements
branch
from
b9179bb
to
f5135bd
Compare
|
chirag04
reviewed
Feb 25, 2020
| eol=$'\n' | ||
| size_report="" | ||
| size_report="| App | Platform | Engine | Arch | Size (bytes) |$eol" |
There was a problem hiding this comment.
suggestion: mb might be easier to mentally parse then bytes.
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @tido64 in 32127e8. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Make the Android app bundle size report more legible, and update existing reports if possible. ## Changelog [Internal] [Changed] - Update existing app bundle size report if possible [Internal] [Changed] - Generate table for APK sizes report Pull Request resolved: facebook#28169 Test Plan: - App bundle size reports should be updated when possible - Android apk sizes should be reported using a table Reviewed By: cpojer Differential Revision: D20141490 Pulled By: hramos fbshipit-source-id: 3fc1b808b27e893c0a3e4e34eafc39094448799c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the Android app bundle size report more legible, and update existing reports if possible.
Changelog
[Internal] [Changed] - Update existing app bundle size report if possible
[Internal] [Changed] - Generate table for APK sizes report
Test Plan