Report size of app bundles on PRs #28019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
tido64
force-pushed
the
tido/report-bundle-size
branch
from
bf989b5
to
64521fe
Compare
|
RNTester.app (iOS): 9846784 bytes |
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Making a slight adjustment - moving octokit/rest from a devDependency in the root package.json, to the bots/package.json file should work as well. It also keeps us from having to add octokit to our internal yarn offline mirror (which is based off the root package.json). I couldn't update bots/package.json in your PR so the latest CI run will likely fail, but you may safely ignore that. I already made these changes internally. |
hramos
pushed a commit
to hramos/react-native
that referenced
this pull request
Feb 12, 2020
Summary: Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 48ba25903356b219135716f989a4a3c05140abfb
|
@hramos Thanks for reviewing this!
Since you've bumped the version number, should we also fix the deprecation warnings? |
hramos
pushed a commit
to hramos/react-native
that referenced
this pull request
Feb 13, 2020
Summary: Pull Request resolved: facebook#28041 Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Reviewed By: cpojer Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 0eb510287ba2001895d66d038fc1e7b8a722d9a8
|
Merged! Yes, we should fix the deprecated warnings. I also filed #28043 as a related item that came up while testing this. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 20, 2020
Summary: Addresses deprecation warnings from `octokit/rest`. This is a follow up to #28019. ## Changelog [Internal] [Fixed] - Address deprecation warnings from `octokit/rest` Pull Request resolved: #28050 Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone. Reviewed By: cpojer Differential Revision: D20008805 Pulled By: hramos fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
|
test |
4 similar comments
|
test |
|
test |
|
test |
|
test |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Pull Request resolved: facebook#28041 Report size of app bundles on PRs. See [React Native Benchmark Suite](react-native-community/discussions-and-proposals#186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: facebook#28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Reviewed By: cpojer Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 3920dc60e6fd073928388e6ae52fc2ba1bc745ac
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Addresses deprecation warnings from `octokit/rest`. This is a follow up to facebook#28019. ## Changelog [Internal] [Fixed] - Address deprecation warnings from `octokit/rest` Pull Request resolved: facebook#28050 Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone. Reviewed By: cpojer Differential Revision: D20008805 Pulled By: hramos fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Report size of app bundles on PRs. See React Native Benchmark Suite for further discussion.
Changelog
[Internal] [Added] - Report size of app bundles on PRs
Test Plan
PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully.