Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address @octokit/rest deprecation warnings #28050

Closed
wants to merge 1 commit into from
Closed

Address @octokit/rest deprecation warnings #28050

wants to merge 1 commit into from

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Feb 13, 2020

Summary

Addresses deprecation warnings from @octokit/rest. This is a follow up to #28019.

Changelog

[Internal] [Fixed] - Address deprecation warnings from @octokit/rest

Test Plan

PRs should still get app bundle sizes report, but the warnings in the build logs should be gone.

@tido64 tido64 requested a review from hramos as a code owner February 13, 2020 08:48
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Feb 13, 2020
@tido64
Copy link
Collaborator Author

tido64 commented Feb 13, 2020

@hramos Will this also address #28043?

@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3276800 bytes
RNTester (Android/hermes/armeabi-v7a): 3117056 bytes
RNTester (Android/hermes/x86): 3442688 bytes
RNTester (Android/hermes/x86_64): 3407872 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4268032 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4646912 bytes

@tido64
Copy link
Collaborator Author

tido64 commented Feb 13, 2020

No more warnings:
image

@tido64
Copy link
Collaborator Author

tido64 commented Feb 13, 2020

@hramos It looks like test_ios_e2e didn't get triggered?

@hramos
Copy link
Contributor

hramos commented Feb 13, 2020

It won’t run if test_js fails. I’m looking at that failure today.

@hramos
Copy link
Contributor

hramos commented Feb 13, 2020

BTW, #28048 fixes test_js, next up I need to see if the test_js_e2e failure already exists in master or not. I'm following up on this later today.

@hramos hramos self-assigned this Feb 20, 2020
facebook-github-bot
facebook-github-bot reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @tido64 in de8fcfb.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added Merged This PR has been merged. and removed Needs: Imported Diff Waiting on Meta labels Feb 20, 2020
@tido64 tido64 deleted the tido/fix-bot-warnings branch February 21, 2020 06:53
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@tido64 @osdnk
Address @octokit/rest deprecation warnings (facebook#28050)
8f9816e 
Summary:
Addresses deprecation warnings from `octokit/rest`. This is a follow up to facebook#28019.

## Changelog

[Internal] [Fixed] - Address deprecation warnings from `octokit/rest`
Pull Request resolved: facebook#28050

Test Plan: PRs should still get app bundle sizes report, but the warnings in the build logs should be gone.

Reviewed By: cpojer

Differential Revision: D20008805

Pulled By: hramos

fbshipit-source-id: 891d14fd9d55f217194a095d2736494416dacda2
@tido64 tido64 mentioned this pull request Mar 12, 2020
Closed
@fabOnReact fabOnReact mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@hramos hramos Awaiting requested review from hramos

Assignees

@hramos hramos

Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tido64 @analysis-bot @hramos @react-native-bot @facebook-github-bot