inline proguard rules #2075
inline proguard rules #2075
Conversation
There was a problem hiding this comment.
@lambdapioneer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@lambdapioneer Has this pr got merged, do I need to close this ? |
|
It's not merged yet :) I've imported it to our internal system to verify it and get comments from my colleagues. Once it is merged, this pull-request will close automatically |
|
Hi @gengjiawen this looks good :) However, can you remove the update of the documentation for now? We'd want to wait with it until we made the new release. |
|
@gengjiawen has updated the pull request. View: changes, changes since last import |
|
@lambdapioneer done. |
There was a problem hiding this comment.
@lambdapioneer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@lambdapioneer Since the new version has been released, I think we need to update the docs. |
Summary: Fresco now maintain proguard rules by itself (facebook/fresco#2075), so it won't be necessary for react native copy its rules. Run RNTTester Android app in release mode, app build successful and won't crash in ImageModule. none [ANDROID] [BUGFIX] [PROGUARD] - remove fresco proguard rules Closes #19040 Differential Revision: D7992146 Pulled By: hramos fbshipit-source-id: 9ee3dd4c6756472395ec9e36a967b469f0760999
Summary: Fresco now maintain proguard rules by itself (facebook/fresco#2075), so it won't be necessary for react native copy its rules. Run RNTTester Android app in release mode, app build successful and won't crash in ImageModule. none [ANDROID] [BUGFIX] [PROGUARD] - remove fresco proguard rules Closes facebook#19040 Differential Revision: D7992146 Pulled By: hramos fbshipit-source-id: 9ee3dd4c6756472395ec9e36a967b469f0760999
Motivation (required)
Android library should maintain their own proguard rules like butterknife, so library user should manually copy and paste proguard rules everytime the rules updated.
Test Plan (required)
Test current sample app works as expect.