Fixed webp native memory leak #2074
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thanks @howardpang ! I'll run this against our internal tests once we have the CLA :) |
|
@facebook-github-bot i have signed CLA just now |
|
Hi @howardpang, can you try the CLA flow again? If it's successful then the bot will add a tag "CLA Signed" to this PR (like here #2075). Let me know when trying again doesn't work and I'll forward it to the team that maintains that flow |
|
@lambdapioneer i have try again, and the result :
|
|
Hi @howardpang, can you mail cla@fb.com with a link to this PR? They should be able to sort it out quickly :) Seems that the GitHub username that was entered had a typo. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@lambdapioneer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| throwIllegalStateException(pEnv, "unable to get frame"); | ||
| WebPDemuxReleaseIterator(&iter); |
There was a problem hiding this comment.
We should also call WebPDemuxReleaseIterator(&iter); in the if (!spFrameNativeContext) branch in lines 451-453
Motivation (required)
Fixed bug #2073
Test Plan (required)
it is a obvious bug, and i found the native memory do not increase when i use this patch