Skip to content

Commit

Permalink
inline proguard rules
Browse files Browse the repository at this point in the history
Summary:
Android library should maintain their own proguard rules like butterknife, so library user should manually copy and paste proguard rules everytime the rules updated.

Test current sample app works as expect.
Closes #2075

Reviewed By: kirwan

Differential Revision: D7380382

Pulled By: lambdapioneer

fbshipit-source-id: fcb50047db89bceb53a6579deb39349ff0a3716f
  • Loading branch information
gengjiawen authored and facebook-github-bot committed Mar 26, 2018
1 parent eb9df5b commit 0e9aba2
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions fbcore/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ android {

useLibrary 'org.apache.http.legacy'

defaultConfig {
consumerProguardFiles 'proguard-fresco.pro'
}

packagingOptions {
exclude 'LICENSE'
exclude 'LICENSE.txt'
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion samples/animation2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
}
}

Expand Down
2 changes: 1 addition & 1 deletion samples/comparison/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
}
}

Expand Down
2 changes: 1 addition & 1 deletion samples/kotlin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
}
}

Expand Down
2 changes: 1 addition & 1 deletion samples/scrollperf/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
}
}

Expand Down
2 changes: 1 addition & 1 deletion samples/showcase/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro', 'proguard-showcase.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-showcase.pro'
}
}
flavorDimensions "main"
Expand Down
2 changes: 1 addition & 1 deletion samples/zoomableapp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android {
buildTypes {
release {
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), '../../proguard-fresco.pro'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt')
}
}

Expand Down

0 comments on commit 0e9aba2

Please sign in to comment.