[Fix] Removing Employee from Project Doesn't Work Despite Success Toast on Employee Page

[samuelmbabhazi]

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

Summary by CodeRabbit

• New Features

  • Enhanced error handling in project member management.
  • Improved logging for better traceability of update issues.

• Bug Fixes

  • Corrected identifier usage in project membership deletion logic.

[samuelmbabhazi]

https://www.loom.com/share/76a5c6f608904289b749c15e4688cf25?sid=dd293957-416b-43f8-9757-31dabdf6d84d

[coderabbitai]

Walkthrough

The changes in this pull request focus on the OrganizationProjectService class within the organization-project.service.ts file. Modifications include improved error handling and updates to the logic for managing project members, specifically in the updateByEmployee method. The identifier used for deleting project memberships has been changed from member.employeeId to member.id, ensuring correct deletion. Additionally, the method now captures and logs errors during the update process, enhancing traceability for issues related to project associations.

Changes

File Path	Change Summary
packages/core/src/organization-project/organization-project.service.ts	- Enhanced error handling in updateByEmployee method. - Changed deletion logic identifier from member.employeeId to member.id. - Added error logging for update process.

Possibly related issues

• [Fix] Removing Employee from Project Doesn't Work Despite Success Toast on Employee Page #8429: The changes in this PR address the issue of removing an employee from a project, which was previously not functioning correctly despite showing a success message.

Possibly related PRs

• [Fix] Edit team functionality not working #8391: This PR modifies the updateByEmployee method in the OrganizationProjectService, enhancing error handling and logic for managing project members, directly relating to the changes in the main PR.
• [Fix] Edit contact for (client,customers,leads) functionality not working  #8393: This PR involves changes to project member management in the assignMembersToProjects method, relevant to the overall context of managing project memberships discussed in the main PR.

Suggested reviewers

• rahul-rocket

Poem

🐇 In the land of projects, hopping with glee,
Changes were made, as bright as can be.
Errors now caught, no more to despair,
With IDs corrected, we handle with care.
So let’s cheer for the service, robust and spry,
Hopping forward, reaching for the sky! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/core/src/organization-project/organization-project.service.ts (1)

573-575: Approve the change and suggest improved error logging

The change from member.employeeId to member.id correctly addresses the issue of removing an employee from a project. This fix ensures that the proper identifier is used when deleting project memberships.

Consider enhancing the error logging in the catch block to include more details about the error:

 } catch (error) {
-    console.log('Error while updating project by employee:', error);
+    console.error('Error while updating project by employee:', error.message, '\nStack:', error.stack);
     throw new HttpException({ message: 'Error while updating project by employee' }, HttpStatus.BAD_REQUEST);
 }

This will provide more comprehensive information for debugging purposes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f4049cd and 719b1f2.

📒 Files selected for processing (1)

• packages/core/src/organization-project/organization-project.service.ts (1 hunks)

🧰 Additional context used

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 719b1f2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx build gauzy -c=production --prod --verbose
nx build desktop --prod --base-href ./

✅ Successfully ran 1 target

• nx build api -c=production --prod

---

Sent with 💌 from NxCloud.