Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Releases (Shanghai Support, EIP-4844 (experimental), Client Improvements) #2521

Merged
merged 31 commits into from
Feb 21, 2023
Merged

New Releases (Shanghai Support, EIP-4844 (experimental), Client Improvements) #2521

merged 31 commits into from
Feb 21, 2023

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Feb 8, 2023 •
edited
Loading

Follow-up on #2445

Full round of client releases, releases are planned for next Tuesday, February 14 2023.

Release round includes full Shanghai support for the libraries, an experimental EIP-4844 Shard Blob Transactions implementation, various sync and UI/UX related client improvements following Interop week.

WIP, submitted CHANGELOGs for selected libraries can be already reviewed.

Ready for review. 🙂

Update: only the @ethereumjs/rlp release done here (Sepolia problems), release process continued in #2549

@codecov
Copy link

codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #2521 (fbb013c) into master (4aa9753) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.12% <ø> (ø)
blockchain 90.11% <ø> (ø)
client 87.69% <ø> (ø)
common 95.82% <ø> (ø)
devp2p 91.74% <ø> (-0.03%) ⬇️
ethash ∅ <ø> (∅)
evm 83.36% <100.00%> (+<0.01%) ⬆️
rlp ∅ <ø> (?)
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (-0.30%) ⬇️
tx 93.71% <ø> (ø)
util 84.50% <ø> (ø)
vm 83.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 changed the title New Releases (Shanghai Support, EIP-4844 (experimental), Client Improvements, EOF continuation) New Releases (Shanghai Support, EIP-4844 (experimental), Client Improvements) Feb 8, 2023
@holgerd77 holgerd77 force-pushed the new-releases branch 2 times, most recently from f4b1913 to 0518539 Compare February 13, 2023 10:16
@holgerd77
Copy link
Member Author

Rebase this and fixed some tx README conflict.

acolytec3
acolytec3 reviewed Feb 13, 2023
View reviewed changes
packages/tx/CHANGELOG.md Outdated Show resolved Hide resolved
@holgerd77
Copy link
Member Author

This is now complete, maybe a bit rough still since I pushed relatively quickly. Nevertheless open for a first round of full review. 🙂

@holgerd77
Copy link
Member Author

Update: ah, just realizing: still forgot the client.

Nevertheless. You can already review.

acolytec3
acolytec3 reviewed Feb 13, 2023
View reviewed changes
packages/tx/CHANGELOG.md Outdated Show resolved Hide resolved
acolytec3
acolytec3 requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just need to add the initKzg line to the usage examples for 4844 in the impacted modules.

@holgerd77
Copy link
Member Author

Ok, this is now ready with an extensive Client CHANGELOG also added. 🙂

It would be good if this would get a deeper round of reviews soon, so that we are ready on Tuesday, this the scope of this PR is pretty extensive. It would be good if all CHANGELOG parts are re-read at least once by someone, also cross-checks on completeness and correctness of version bumps would be useful.

holgerd77 and others added 16 commits February 20, 2023 22:33
@holgerd77
Additional fixes
42f69a4
@holgerd77
Even more fixes
e2b0e1e
@holgerd77
Added CHANGELOG entry, version bump, updated upstream dependency vers…
f2bf39a 
…ions (@ethereumjs/blockchain v6.2.0)
@holgerd77
Rebuild blockchain documentation
6aa2001
@holgerd77
Added CHANGELOG entry, version bump, updated upstream dependency vers…
7c55672 
…ions (@ethereumjs/evm v1.3.0)
@holgerd77
Rebuild EVM documentation
55e2fe9
@holgerd77
Added CHANGELOG entry, version bump, updated upstream dependency vers…
82613a3 
…ions (@ethereumjs/vm v6.4.0)
@holgerd77
Added CHANGELOG entry, version bump, updated upstream dependency vers…
145534c 
…ions (@ethereumjs/block v4.2.0)
@holgerd77
Tx libray KZG setup instruction generalization
2c632d9
@holgerd77
Create and consolidate KZG setup instructions within a single source …
18e253d 
…of truth, add references
@holgerd77
Added 4844 and KZG setup instructions and refernces to the Blockchain…
a547086 
… library
@holgerd77
Fixes
6712256
@holgerd77
Bumped client version to v0.7.0, added CHANGELOG entry
77c642b
@holgerd77
Rebuild package-lock.json
dace7d6
@holgerd77 @acolytec3
Update packages/client/CHANGELOG.md
c9021fb 
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
@holgerd77
Completed CHANGELOG files
1e822d9
gabrocheleau
gabrocheleau reviewed Feb 20, 2023
View reviewed changes
packages/util/CHANGELOG.md
Comment on lines +12 to +13
- New `GWEI_TO_WEI` constant in a newly created `units` module, PR [#2483](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2483)
- Change withdrawal amount representation from Wei to Gwei (see EIP-4895 PR [#6325](https://github.com/ethereum/EIPs/pull/6325)) in `withdrawal` module `Withdrawal` class, PR [#2483](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2483)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated #2483 to link the PR number but just noticed it's already refered to above. Could we actually merge the two points into one?

gabrocheleau
gabrocheleau approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. left one small comment.

@holgerd77 holgerd77 merged commit 1a7094d into master Feb 21, 2023
@holgerd77 holgerd77 deleted the new-releases branch February 21, 2023 07:48
@holgerd77
Copy link
Member Author

@gabrocheleau thanks for the continued reviews, sorry sorry, I just realized that I force-pushed your other updates away yesterday accidentally. 😳

I will nevertheless continue with the releases, this would otherwise hold up the process too much. Maybe we can still add in a follow up PR.

Again, sorry, was a bit tired.

g11tech
g11tech reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good 👍

@holgerd77 holgerd77 mentioned this pull request Feb 23, 2023
Merged
@holgerd77 holgerd77 mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech left review comments

@gabrocheleau gabrocheleau gabrocheleau approved these changes

@acolytec3 acolytec3 acolytec3 left review comments

Assignees
No one assigned
Labels
package: block package: blockchain package: client package: common package: devp2p package: ethash package: evm package: mpt package: rlp package: statemanager package: tx package: util package: vm PR state: needs review type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerd77 @acolytec3 @gabrocheleau @g11tech