util: Change withdrawal amount representation from Wei to Gwei

[g11tech]

util: Change withdrawal amount representation for Wei to Gwei

ref:

• https://github.com/ethereum/EIPs/pull/6325/files
• CL-EL withdrawals harmonization: using units of Gwei ethereum/execution-apis#354

[codecov]

Codecov Report

Merging #2483 (9b14652) into master (9b14652) will not change coverage.
The diff coverage is n/a.

❗ Current head 9b14652 differs from pull request most recent head 8a20fa2. Consider uploading reports for the commit 8a20fa2 to get more accurate results

Additional details and impacted files

Flag	Coverage Δ
block	89.57% <0.00%> (ø)
blockchain	90.04% <0.00%> (ø)
client	87.91% <0.00%> (ø)
common	95.89% <0.00%> (ø)
devp2p	91.62% <0.00%> (ø)
ethash	∅ <0.00%> (∅)
evm	79.73% <0.00%> (ø)
rlp	∅ <0.00%> (∅)
statemanager	89.61% <0.00%> (ø)
trie	90.66% <0.00%> (ø)
tx	97.80% <0.00%> (ø)
util	84.74% <0.00%> (ø)
vm	85.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

Hmm, given that we had these endless discussions and drafts on unit conversion, latest with #1842, I would feel uneasy if we now side introduce such a constant GWEI_TO_WEI, and then even in the withdrawals Util module.

On the other hand I agree that this is super-helful, even in this raw "just the factor" constant. 😋

Can we at least move this to a dedicated new module units, where we can eventually expand from, maybe add 1-2 other small helper methods e.g. (and level down a bit from our previous ambitions)?

That would feel better to me, having this in withdrawals would cause some level of technical debt - since people might directly import - if we finally want to expand a bit on the topic and include in a release.

[g11tech]

Hmm, given that we had these endless discussions and drafts on unit conversion, latest with #1842, I would feel uneasy if we now side introduce such a constant GWEI_TO_WEI, and then even in the withdrawals Util module.

On the other hand I agree that this is super-helful, even in this raw "just the factor" constant. yum

Can we at least move this to a dedicated new module units, where we can eventually expand from, maybe add 1-2 other small helper methods e.g. (and level down a bit from our previous ambitions)?

That would feel better to me, having this in withdrawals would cause some level of technical debt - since people might directly import - if we finally want to expand a bit on the topic and include in a release.

sounds good!

[g11tech]

@holgerd77 i have created a minimal module @ethereumjs/units and move the GWEI_TO_WEI constant there, for now i guess this should be sufficient and can extend withdrawal along the way if needed

[g11tech]

rebased via ui

[holgerd77]

Rebased this via UI

[holgerd77]

Looks good now! 👍