Skip to content

Commit

Permalink
Update packages/blockchain/CHANGELOG.md
Browse files Browse the repository at this point in the history
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
  • Loading branch information
holgerd77 and gabrocheleau committed Feb 20, 2023
1 parent f739679 commit 6d381c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/blockchain/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ So the Blockchain interface was - falsely - claiming that there would be the pos

We now fixed this by removing the `null` from the interface return values - see PR [#2524](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2524), after exploring the other way around as well (and the reverting), see PR [#2516](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2516).

While this might lead to breaking code constallations on the TypeScript level if this `null` value is picked up we felt this is the right thing to do since this divergence would otherwise continue to "trick" people into assuming and dealing with `null` values for non-existing-block assumptions in their code and continue to produce eventual bugs (we actually fell over this ourselves).
While this might lead to breaking code installations on the TypeScript level if this `null` value is picked up we felt this is the right thing to do since this divergence would otherwise continue to "trick" people into assuming and dealing with `null` values for non-existing-block assumptions in their code and continue to produce eventual bugs (we actually fell over this ourselves).

A bit on the verge of breaking vs. bug fixing, sorry if you are eventually affected, but we just can't do a single breaking release update for a fix on that level.

Expand Down

0 comments on commit 6d381c9

Please sign in to comment.