Separate input modes for --help, --license and --version
#12118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
cameel
force-pushed
the
separate-input-modes-for-help-license-version
branch
2 times, most recently
from
c8b09a3 to
ef8d52f
Compare
|
Note: this is now based on the CI fix (#12106). |
cameel
force-pushed
the
separate-input-modes-for-help-license-version
branch
from
ef8d52f to
a168953
Compare
cameel
force-pushed
the
separate-input-modes-for-help-license-version
branch
2 times, most recently
from
adefbd8 to
531ea36
Compare
- The distinction between them is not as clear-cut as it should be. For example processInput() prints output in assembly mode.
cameel
force-pushed
the
separate-input-modes-for-help-license-version
branch
from
531ea36 to
0417db0
Compare
leonardoalt
approved these changes
Nov 3, 2021
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves part of #11731.
Alternative approach for #11800.
To properly finish #11800 I need to remove the
exit()from the code that prints license and version. Doing this complicates the control flow and I think that the right solution is to change that flow and actually treat--help,--license, and--versionas separate input modes. This way we can properly move them toCommandLineInterfaceand only do actual parsing inCommandLineParser.