Don't return an error from --help

ethereum · Oct 11, 2021 · ef8d52f · ef8d52f
1 parent 5f7245f
commit ef8d52f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp
@@ -605,7 +605,7 @@ bool CommandLineInterface::processInput()
 	{
 	case InputMode::Help:
 		CommandLineParser::printHelp(sout());
-		return false;
+		break;
 	case InputMode::License:
 		printLicense();
 		break;

diff --git a/test/solc/CommandLineInterface.cpp b/test/solc/CommandLineInterface.cpp
@@ -116,7 +116,7 @@ BOOST_AUTO_TEST_CASE(help)
 {
 	OptionsReaderAndMessages result = parseCommandLineAndReadInputFiles({"solc", "--help"}, "", /* _processInput */ true);
 
-	BOOST_TEST(!result.success);
+	BOOST_TEST(result.success);
 	BOOST_TEST(boost::starts_with(result.stdoutContent, "solc, the Solidity commandline compiler."));
 	BOOST_TEST(result.stderrContent == "");
 	BOOST_TEST(result.options.input.mode == InputMode::Help);