Graceful error handling in soltest/isoltest + improved soltestAssert() #12283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
soltest-graceful-error-handling
branch
2 times, most recently
from
2ff6cfd to
a970f9f
Compare
christianparpart
suggested changes
Nov 22, 2021
cameel
force-pushed
the
soltest-graceful-error-handling
branch
from
a970f9f to
8f692a6
Compare
Marenz
previously approved these changes
Dec 2, 2021
cameel
force-pushed
the
soltest-graceful-error-handling
branch
from
8f692a6 to
eab8b3a
Compare
cameel
force-pushed
the
soltest-graceful-error-handling
branch
from
eab8b3a to
8de47e6
Compare
|
Rebased on |
cameel
force-pushed
the
soltest-graceful-error-handling
branch
from
8de47e6 to
0bb2050
Compare
|
Has conflicts |
|
Still has conflicts. |
|
Just needs a rebase (and another look from @christianparpart :)). Otherwise it should be fine. |
christianparpart
suggested changes
Apr 6, 2022
- Allow omitting description. - Provide a default description. - Use a custom exception type derived from util::Exception rather than std::exception.
cameel
force-pushed
the
soltest-graceful-error-handling
branch
from
0bb2050 to
b3048cc
Compare
|
Ready for another round of review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11917.
While working on #12282 I hit an assertion in
ByteUtilsbut it looked like something completely different. That's becausesoltestAssert()throwsstd::runtime_errorrather than some special exception type reserved for assertions. I also noticed that in #12019 I did not coversoltestAssert(). This PR refactors the macro to be in line withsolAssert(), i.e. allow skipping the message, provide a default message and use a dedicated exception type.I have also added exception handlers that intercept normal errors (like command-line validation errors) and print them in a way that does not make you think you hit a bug.
Also,
--helpno longer returns an error code. It's normal and expected behavior. A similar change was made forsolcin #12118.I recommend reviewing with the option to ignore whitespace changes enabled - changes are actually small but some blocks had to be reindented due to the added
try/catch.