Packing UserOperation and paymaster gas limits #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing obsolete gnosis safe module
* add separate test for paymaster with postOp we use our "gas tests" to check the impact of specific version. it is important to to break tests. This PR make "simple paymaster" simple again, and adds a separte test of "paymaster with postOp" tests are ordered so that they can be directly diff'ed with (say) v0.6.0 contracts * separate TestPaymasterWithPostOp
* upgrade solidity to 0.8.23 * Use OpenZeppelin v0.5
* AA-237: paymaster: check EntryPoint's interface verify the paymaster is configured with EntryPoint with the expected IEntryPoint interface. * update sample for contract with supportsInterface() method
process the entire UserOp during account execution. The account MAY implement a method: ```javascript function executeUserOp(UserOperation userOp, bytes32 userOpHash) ``` if it needs parts of the UserOp during its execution. (note that account is not required to use it: it may continue to use standard "execute" methods, and even support both calling conventions, for different userops) To signal the EntryPoint to call this method, the wallet should start the `userOp.callData` with the "magic" value - `executeUserOp.selector` Note that the calldata is no longer directly callable - since obviously the rest of the callData is NOT the parameters of executeUserOp. The account should parse the callData to remove this 4-byte prefix and process the rest of the callData as it sees fit. See the `TestExecAccount` for a sample that uses this callData. The calling wallet should properly encode this call data. ### Passing information between validation and execution. If the account needs to transfer information from the validateUserOp to the executeUserOp, it should use storage (or, when available, `transient storage`) based on the **userOpHash**, which is the same value for both validate and execute.
update storage mapping for major use-case (handleOps)
drortirosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplement the main "Packing UserOperation" PR: #363