gas-optimize deposit #390
Merged
gas-optimize deposit #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update storage mapping for major use-case (handleOps)
forshtat
reviewed
Jan 2, 2024
| if (x == 123) { | ||
| return; | ||
| unchecked{ | ||
| uint g = gasleft(); |
There was a problem hiding this comment.
Its a code to waste some gas... we must make sure that the simulation contract always takes more gas, otherwise, it can be used to attack the bundler.
The previous "gas waster" didn't pass the tests, but wasn't easily adaptable, so I changed it to waste gas in a loop.
Strangely, the different functions (with/without value, using fallback or "depositTo") have different delta from the real entrypoint code. so I had to make sure it is above for all.
forshtat
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update storage mapping for major use-case (handleOps)
deposit as uint256 makes handling deposit in handleOps slightly cheaper (300gas per op).
probably makes stake() cost a little higher (up to 15000 more, though didn't check its cost) - but that's one-time, even for the paymaster...