AA-237: paymaster: check EntryPoint's interface #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
force-pushed
the
paymaster-check-ep-supportedInterface
branch
from
c57378e to
e683e7e
Compare
verify the paymaster is configured with EntryPoint with the expected IEntryPoint interface.
drortirosh
force-pushed
the
paymaster-check-ep-supportedInterface
branch
from
e683e7e to
ffce6e1
Compare
drortirosh
changed the title
forshtat
requested changes
Dec 10, 2023
| @@ -68,6 +68,11 @@ describe('EntryPoint with paymaster', function () { | |||
| ownerAddr = await ethersSigner.getAddress() | |||
| }) | |||
|
|
|||
| it('paymaster should revert on wrong entryPoint type', async () => { | |||
| await expect(new LegacyTokenPaymaster__factory(ethersSigner).deploy(factory.address, 'ttt', AddressZero)) | |||
| .to.be.revertedWith('') | |||
There was a problem hiding this comment.
@drortirosh don't you get a full revert message here?
There was a problem hiding this comment.
zero address reverts with empty string.
added a test with some contract with different supportsInterface.
shahafn
previously approved these changes
Jan 2, 2024
forshtat
previously approved these changes
Jan 2, 2024
forshtat
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify the paymaster is configured with EntryPoint with the expected IEntryPoint interface.