Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main branch to Go 1.23 / release branches to 1.22 #18443

Closed
7 of 9 tasks
ivanvc opened this issue Aug 14, 2024 · 9 comments
Closed
7 of 9 tasks

Update main branch to Go 1.23 / release branches to 1.22 #18443

ivanvc opened this issue Aug 14, 2024 · 9 comments
Assignees
@henrybear327
Labels
area/security area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Aug 14, 2024 •
edited
Loading

What would you like to be added?

Go 1.23.0 was released yesterday. Therefore, Go 1.21 will be out of support when 1.24.0 is released. We should update the main branches to Go 1.23 and the release branches to 1.22.

Completion tracking below:

Why is this needed?

To keep the project up to date with the latest released Go version and run on supported versions.
@jmhbnz jmhbnz added area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 14, 2024
@henrybear327
Copy link
Contributor

/assign

henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.23.0
fbd70e8 
Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.22.6
f990785 
Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.22.6
307e307 
Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
This was referenced Aug 14, 2024
Merged
Merged
henrybear327 added a commit to henrybear327/bbolt that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.23.0
e52dec6 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
henrybear327 added a commit to henrybear327/bbolt that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.22.6
9374ef9 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
henrybear327 added a commit to henrybear327/gofail that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.22.6
8e7588d 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
henrybear327 added a commit to henrybear327/auger that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.23.0
5178c37 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
henrybear327 added a commit to henrybear327/raft that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.23.0
e001044 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
henrybear327 added a commit to henrybear327/raft that referenced this issue Aug 14, 2024
@henrybear327
Bump go toolchain to 1.23.0
854807c 
Reference:
- etcd-io/etcd#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Aug 14, 2024
Merged
@henrybear327
Copy link
Contributor

There is an issue with the golangci-lint tool that I will need to deal with.

@ivanvc
Copy link
Member Author

ivanvc commented Aug 14, 2024

@jmhbnz, should we lower the priority due to #18444 (comment)?

@jmhbnz
Copy link
Member

jmhbnz commented Aug 15, 2024

@jmhbnz, should we lower the priority due to #18444 (comment)?

I think priority is still important/soon but it's ok to wait a little bit for the devcontainer to be published in order to update etcd-io/main. We can proceed with updating to go 1.22 for stable release branches in the interim imo.

@henrybear327
Copy link
Contributor

@jmhbnz, should we lower the priority due to #18444 (comment)?

I think priority is still important/soon but it's ok to wait a little bit for the devcontainer to be published in order to update etcd-io/main. We can proceed with updating to go 1.22 for stable release branches in the interim imo.

How about we update the devcontainer as a subsequent step?

I am not sure how long it will take the devcontainer team to release the new Go version ... :(

@henrybear327
Copy link
Contributor

@jmhbnz @ivanvc @ahrtr Currently only the main etcd branch is still undergoing changes to fix the CI pipeline, but all other PRs should be ready for review!! :)

@ahrtr
Copy link
Member

ahrtr commented Aug 22, 2024

@henrybear327 Please raise a PR to update changelog for 3.4 and 3.5. thanks

henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 24, 2024
@henrybear327
Bump go toolchain to 1.23.0
aa6195d 
Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Sep 2, 2024
@henrybear327
Bump go toolchain to 1.23.0
2a31a38 
Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@ivanvc ivanvc mentioned this issue Sep 5, 2024
Open
10 tasks
@ivanvc
Copy link
Member Author

ivanvc commented Sep 5, 2024

Closing, as #18548 supersedes this issue. I'll update the CHANGELOG once we close the 3.4 and 3.5 pull requests.

@ivanvc ivanvc closed this as completed Sep 5, 2024
@henrybear327
Copy link
Contributor

@henrybear327 Please raise a PR to update changelog for 3.4 and 3.5. thanks

Sorry that I definitely missed this comment...

henrybear327 added a commit to henrybear327/etcd that referenced this issue Sep 11, 2024
@henrybear327
Bump go toolchain to 1.22.7
032f81c 
Reference:
- etcd-io#18443
- etcd-io#18548 (comment)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Sep 11, 2024
@henrybear327
Bump go toolchain to 1.22.7
29f3bc2 
Reference:
- etcd-io#18443
- etcd-io#18548 (comment)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@ivanvc ivanvc mentioned this issue Sep 12, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrybear327 henrybear327

Labels
area/security area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ivanvc @henrybear327 @ahrtr @jmhbnz