Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Bump go toolchain to 1.22.7 #18444

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

@henrybear327
Copy link
Contributor Author

henrybear327 commented Aug 14, 2024

@ivanvc The devcontainer can't be updated now, because at the time of writing the 1.23 image hasn't been released yet.

Please see: https://hubgw.docker.com/r/microsoft/devcontainers-go

henrybear327 added a commit to henrybear327/etcd that referenced this pull request Aug 14, 2024
Reference:
- etcd-io#18444

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 force-pushed the go/1.23.0 branch 2 times, most recently from 93d1f98 to fbd70e8 Compare August 14, 2024 21:52
@henrybear327 henrybear327 marked this pull request as draft August 14, 2024 21:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (5088131) to head (2d0982e).

Current head 2d0982e differs from pull request most recent head 29f3bc2

Please upload reports for the commit 29f3bc2 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18444      +/-   ##
==========================================
- Coverage   68.85%   68.81%   -0.04%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
- Hits        24425    24411      -14     
- Misses       9626     9639      +13     
- Partials     1423     1424       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5088131...29f3bc2. Read the comment docs.

@henrybear327
Copy link
Contributor Author

@ivanvc I will resolve the CI error in the meantime. But we probably would be blocked by #18444 (comment) in any case.

@ahrtr
Copy link
Member

ahrtr commented Aug 19, 2024

/test pull-etcd-govulncheck

@ahrtr
Copy link
Member

ahrtr commented Aug 19, 2024

For the pull-etcd-govulncheck failure, it should be caused the by environment. We might want to raise an issue to the kubernetes/test-infra

@jmhbnz
Copy link
Member

jmhbnz commented Aug 23, 2024

Hey Team - The devcontainer is now available following devcontainers/images#1167

@henrybear327
Copy link
Contributor Author

For the pull-etcd-govulncheck failure, it should be caused the by environment. We might want to raise an issue to the kubernetes/test-infra

Hello @ahrtr,

Thanks for the idea and insight!

May I ask where exactly I should raise this issue?

Thank you!

@ivanvc
Copy link
Member

ivanvc commented Aug 24, 2024

May I ask where exactly I should raise this issue?

I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2.

@henrybear327
Copy link
Contributor Author

May I ask where exactly I should raise this issue?

I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2.

Thanks @ivanvc for the hint.

I dug into the issue. As the k/k is still on 1.22, thus all the images are on 1.22 and not 1.23.

I am thinking of submitting a PR to add a new variant that contains 1.23, but not sure if this is the best way to do it.

@ivanvc do you have some ideas? I am happy to get involved in the prow / test-infra to get into this new field! :)

@ivanvc
Copy link
Member

ivanvc commented Sep 3, 2024

@henrybear327, if you have the time and know what to do, I'd say go for it. :)

@ivanvc
Copy link
Member

ivanvc commented Sep 5, 2024

@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks.

@henrybear327
Copy link
Contributor Author

@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks.

Ok!

Should I bump others too?

@ivanvc
Copy link
Member

ivanvc commented Sep 5, 2024

Yes, if you want, please refer to #18548 (and assign it to you). I'm doing 3.4 and 3.5 because we want to expedite them for the releases.

.go-version Outdated Show resolved Hide resolved
@ivanvc
Copy link
Member

ivanvc commented Sep 5, 2024

/retitle [main] Bump go toolchain to 1.23.1

@k8s-ci-robot k8s-ci-robot changed the title [main] Bump go toolchain to 1.23.0 [main] Bump go toolchain to 1.23.1 Sep 5, 2024
@henrybear327 henrybear327 changed the title [main] Bump go toolchain to 1.23.1 [main] Bump go toolchain to 1.22.7 Sep 11, 2024
@henrybear327
Copy link
Contributor Author

@ahrtr @ivanvc as we have discussed at #18548 (comment) and offline, we will use 1.22.7 for the main branch now.

I will work on the test-infra image in the meantime and if I can get the 1.23.1 image working we can then upgrade the main branch to 1.23.1!

Reference:
- etcd-io#18443
- etcd-io#18548 (comment)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @henrybear327

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit fdbde77 into etcd-io:main Sep 11, 2024
45 checks passed
@henrybear327 henrybear327 deleted the go/1.23.0 branch September 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants