Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Bump go toolchain to 1.22.6 #18445

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

Reference:
- etcd-io#18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 changed the title Bump go toolchain to 1.22.6 [release-3.4] Bump go toolchain to 1.22.6 Aug 14, 2024
@henrybear327
Copy link
Contributor Author

/retest

1 similar comment
@henrybear327
Copy link
Contributor Author

/retest

@ivanvc
Copy link
Member

ivanvc commented Aug 15, 2024

The first part of the issue with the functional tests is that there's a trailing whitespace in the key of the map here (which was very obscure to find; note the "/trace "):

m[HTTPPrefixPProf+"/trace "] = http.HandlerFunc(pprof.Trace)

It should be

m[HTTPPrefixPProf+"/trace"] = http.HandlerFunc(pprof.Trace)

After fixing that, there are still more test failures 😅

Reference:
- etcd-io#18445 (comment)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Henry.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit c12e955 into etcd-io:release-3.4 Aug 16, 2024
18 checks passed
@henrybear327
Copy link
Contributor Author

The first part of the issue with the functional tests is that there's a trailing whitespace in the key of the map here (which was very obscure to find; note the "/trace "):

m[HTTPPrefixPProf+"/trace "] = http.HandlerFunc(pprof.Trace)

It should be

m[HTTPPrefixPProf+"/trace"] = http.HandlerFunc(pprof.Trace)

After fixing that, there are still more test failures 😅

Thanks for digging into this @ivanvc !!

It's actually the only part besides the linter issue which blocked the CI!

@henrybear327 henrybear327 deleted the 3.4_go/1.22.0 branch August 16, 2024 23:39
@ivanvc
Copy link
Member

ivanvc commented Aug 16, 2024

Thanks for digging into this @ivanvc !!

It's actually the only part besides the linter issue which blocked the CI!

Yes, I realized later that some local changes were the cause of my other errors 🙊

@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2024

/retitle [3.4] Bump go toolchain to 1.22.6

@k8s-ci-robot k8s-ci-robot changed the title [release-3.4] Bump go toolchain to 1.22.6 [3.4] Bump go toolchain to 1.22.6 Aug 22, 2024
@ivanvc ivanvc mentioned this pull request Aug 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants