Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing hysteresis filter option for esp32h2 in gpio #387

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

Vollbrecht
Copy link
Collaborator

@Vollbrecht
Copy link
Collaborator Author

@SergioGasquez this should fix the h2 problem

@Vollbrecht
Copy link
Collaborator Author

@ivmarkov this fixes nightly clippy + makes h2 buildable again needed for esp-idf-template and stuff

@ivmarkov ivmarkov merged commit 143db47 into esp-rs:master Mar 6, 2024
8 checks passed
@ivmarkov
Copy link
Collaborator

ivmarkov commented Mar 6, 2024

Thanks! Any idea why the build fails with ESP IDF master?

@Vollbrecht
Copy link
Collaborator Author

Thanks! Any idea why the build fails with ESP IDF master?

i think its ci acting wired when trying to install it and not with anything around actually building it?

@SergioGasquez
Copy link
Member

Is there any scheduled release to have this fix released? @ivmarkov @Vollbrecht

@ivmarkov
Copy link
Collaborator

Not really. I would like to do an incremental release of the crates in the next couple of weeks, but I wanted to first:

  • Check and see how to fix the build for Mac OS (the latest version of the Rust CC crate is the problem there)
  • Check and see how to fix the build for ESP IDF master. It seems a python env var is missing in latest ESP IDF master

Unfortunately, I don't really have much time right now, to look at any of these two issues. Any help would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H2 is failing due to hysteresis control mode
3 participants