-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for #174, cc crate failing on macOS #208
Conversation
Yeah for the current time it seams to be the best option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks adding the workaround! Lets add it and remove it once we have new releases.
This backports esp-rs/esp-idf-template#208 to this project template.
This backports esp-rs/esp-idf-template#208 to this project template.
@sirhcel This PR is mentioning esp-rs/esp-idf-hal#387 but I think this link is completely unrelated to the issue at hand. Isn't it? |
Yes, esp-rs/esp-idf-hal#387 is unrelated. I misread #174 (comment) in the first place. Thank you for spotting this @ivmarkov! Fixed the description here. |
Where is "here"? |
The description of this PR (#208). I see that the hint somewhat hidden as (edited) in the top bar of #208 (comment) and I should have stated this more clearly in the first place. 😅 |
The problem is this line in the (now merged) PR, as it is mentioning a completely unrelated issue. So potentially anybody who is generating a new project will have this wrong comment in his Would you create a mini-PR removing the reference to the completely unrelated issue? |
Sorry, I messed this reference up @ivmarkov. Thank you for already cleaning this up in the meantime @Vollbrecht! ❤️ |
I've hit this trap several times during the last weeks. #174 describes it and the solution. But every time I hit it, I just had forgotten about it which was quite annoying.
The workaround apparently does not affect Linux (while I can't test on Windows). So why not shipping it until #174 gets resolved and released.