rpcdaemon: fix Engine API V3 in JSON-RPC spec #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
added
the
maintenance
canepat
force-pushed
the
rpc_fix_jsonrpc_spec_engine_v3
branch
from
039bf96 to
cac2200
Compare
JacekGlen
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes schema definitions for
PayloadAttributesparameter ofenginemethods in JSON-RPC specification and thepatternformat for some other parameters. Specifically:PayloadAttributesparameter is optional andnullis a valid value as documented inengine_forkchoiceUpdatedV1,engine_forkchoiceUpdatedV2,engine_forkchoiceUpdatedV3gasUsed,blobGasUsedandexcessBlobGasin ExecutePayloadV1, ExecutePayloadV2, ExecutePayloadV3 should haveQUANTITYsyntax and hence value0x0is valid (e.g. such value is sent by Prysm)Moreover, this PR improves the error messages in our JSON-RPC validator and adds some unit tests covering these cases.
Depends on #1920