Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc, sync: support Engine API V3 #1931

Merged
merged 10 commits into from
Mar 27, 2024
Merged

rpc, sync: support Engine API V3 #1931

merged 10 commits into from
Mar 27, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Mar 22, 2024

This PR introduces in RPC Daemon and Sync components the necessary changes to support Engine API V3 as per Cancun hard-fork.

Moreover, a couple of small changes are also included:

  • PoS sync keeps track of the number of received payload validation requests and early returns SYNCING as payloadStatus if any chain validation is already in progress
  • some hard-coded error codes in RPC request handler have been replaced with rpc::ErrorCode constants

Depends on #1924

@canepat canepat added the enhancement New feature or improvement label Mar 22, 2024
@canepat canepat requested review from JacekGlen and lupin012 March 22, 2024 08:58
@yperbasis yperbasis added the cancun The Cancun protocol upgrade label Mar 22, 2024
Base automatically changed from rpc_fix_jsonrpc_spec_engine_v3 to master March 25, 2024 14:18
JacekGlen
JacekGlen approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@JacekGlen JacekGlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Some minor comments, but can be ignored

silkworm/rpc/json/execution_payload.cpp Show resolved Hide resolved
silkworm/rpc/json/execution_payload.cpp Show resolved Hide resolved
silkworm/sync/sync_pos.hpp Show resolved Hide resolved
@canepat
fix validation checks for V3 fields
422b080 
add missing serialization for V3 fields
add unit tests
@canepat canepat merged commit d574f5e into master Mar 27, 2024
4 checks passed
@canepat canepat deleted the rpc_engine_api_v3 branch March 27, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacekGlen JacekGlen JacekGlen approved these changes

@lupin012 lupin012 Awaiting requested review from lupin012

Assignees
No one assigned
Labels
cancun The Cancun protocol upgrade enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canepat @JacekGlen @yperbasis @web-flow