Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: improve JSON embedding #1920

Merged
merged 3 commits into from
Mar 20, 2024
Merged

cmd: improve JSON embedding #1920

merged 3 commits into from
Mar 20, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Mar 19, 2024

This PR generally improves the tooling for JSON embedding we currently use to generate code bindings for genesis network configurations and JSON-RPC specification.

Specifically:

  • rename genesistool as embed_json to better capture the intended usage
  • properly support generation for JSON-RPC specification by adding missing command-line options
  • add generation procedure for genesis files and JSON-RPC spec in contribution guide
  • regenerate genesis configurations and JSON-RPC specification

canepat added 3 commits March 19, 2024 11:51
cmd: rename genesistool as embed_json
docs: add generation procedure for genesis files and JSON-RPC spec
core: regenerate genesis configurations
rpc: regenerate JSON-RPC specification
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 19, 2024
@canepat canepat merged commit d8180a7 into master Mar 20, 2024
4 checks passed
@canepat canepat deleted the cmd_embed_json_tool branch March 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants