Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call correct time function #651

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

joakim-hove
Copy link
Contributor

@joakim-hove joakim-hove commented Sep 4, 2019

Followup fix to: #642

A central element in #642 is to break down a time_t value to a full datetime (year, month, day, hour, minute, second) - where it was previously only broken down to (year,month,day). Unfortunately there was a bug in #642 which lead to the (hour, minute, second) part to be undefined.

@bska
Copy link
Contributor

bska commented Sep 4, 2019

Does this return the seconds as seconds (0..59) or as microseconds (0..59,999,999)?

@joakim-hove
Copy link
Contributor Author

Does this return the seconds as seconds (0..59) or as microseconds (0..59,999,999)?

seconds (0..59) - it is ultimately based on unix gmtime_r which has seconds resolution; and it goes in and out of the function as unix time_t.

@jokva jokva merged commit a9d4dd9 into equinor:master Sep 6, 2019
@joakim-hove joakim-hove deleted the fix-ecl-util-datetime-values branch September 6, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants