Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to enum changes #1986

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Adapt to enum changes #1986

merged 1 commit into from
Sep 4, 2019

Conversation

joakim-hove
Copy link
Member

Followup to: OPM/opm-common#972

@joakim-hove joakim-hove mentioned this pull request Aug 27, 2019
Merged
@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@joakim-hove joakim-hove force-pushed the enum-refactor branch 2 times, most recently from 0cd22c0 to 15bb4e1 Compare August 30, 2019 05:25
@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@joakim-hove joakim-hove force-pushed the enum-refactor branch 2 times, most recently from 700499a to 376dcc6 Compare September 2, 2019 09:08
@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@joakim-hove joakim-hove closed this Sep 2, 2019
@joakim-hove joakim-hove reopened this Sep 2, 2019
@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@bska
Copy link
Member

bska commented Sep 3, 2019 

opm/simulators/wells/WellInterface.hpp:32:70: fatal error: opm/parser/eclipse/EclipseState/Schedule/ScheduleEnums.hpp: No such file or directory

You've only updated WellInterface_impl.hpp in this PR.

@joakim-hove
Copy link
Member Author

You've only updated WellInterface_impl.hpp in this PR.

Hmm - yes you are right; I have updated the WellInterface.hpp as well - but I must have missed it in git.

@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@joakim-hove
Copy link
Member Author

Is master all green now?

@akva2
Copy link
Member

akva2 commented Sep 4, 2019

no. jenkins bump to dune 2.6 has left a few regtest broken + a unit test in opm-grid (i have opened a pr for that one).

@joakim-hove
Copy link
Member Author

Ok - thank you.

@akva2
Copy link
Member

akva2 commented Sep 4, 2019

the regtests that broke are due to uninitialized data output by libecl. since this code will be replaced soonish, i suggest we just update and move on for now.

@GitPaean
Copy link
Member

GitPaean commented Sep 4, 2019 •
edited
Loading

mpi.compareECLFiles_flow+SPE1CASE2_OILGAS
mpi.compareECLFiles_flow+2D_OILWATER_POLYMER

The change of DUNE version can break the two phase cases due to different algorithms of inverting a small matrix.

@akva2
Copy link
Member

akva2 commented Sep 4, 2019

i see, so there may be two things at play then.

@atgeirr
Copy link
Member

atgeirr commented Sep 4, 2019

The change of DUNE version can break the two phase cases due to different algorithms of inverting a small matrix.

True, but in this case there have also been observed some valgrind anomalies from libecl. Both sources could contribute.

@atgeirr
Copy link
Member

atgeirr commented Sep 4, 2019

I think we should just do an update_data now, but not let the valgrind observation die either.

@akva2
Copy link
Member

akva2 commented Sep 4, 2019

equinor/resdata#651 takes care of the valgrind issue.

@joakim-hove
Copy link
Member Author

jenkins build this opm-common=972 please

@joakim-hove joakim-hove merged commit ef3a159 into OPM:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joakim-hove @bska @akva2 @GitPaean @atgeirr