Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use six elements from summary STARTDAT keyword #642

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

joakim-hove
Copy link
Contributor

@joakim-hove joakim-hove commented Aug 1, 2019

In a summary SMSPEC file the start time of the simulation is encoded in the STARTDAT keyword. In current version of libecl this is encoded as a three element integer with DAY, MONTH, YEAR, but it turns out that it can optionally also be stored as a six element vector with addition elements HOUR, MINUTE, MICRO_SECOND.

This PR adds the three new elements HOUR, MINUTE, MICRO_SECOND - and optionally reads them if they are present in the file when reading.

@andreabrambilla
Copy link
Contributor

@joakim-hove @jokva
It appears that this PR has broken a couple of tests in libres related to the simulation context. The issue is a bit nasty to debug as it occures only on osx on travis (see https://travis-ci.org/equinor/libres/jobs/571240984)
Do you have any idea what might be the connection between this specific PR and those tests?

@joakim-hove
Copy link
Contributor Author

It appears that this PR has broken a couple of tests in libres related to the simulation context. The issue is a bit nasty to debug as it occures only on osx on travis (see https://travis-ci.org/equinor/libres/jobs/571240984)
Do you have any idea what might be the connection between this specific PR and those tests?

I have no idea - and quite frankly I find it a bit hard to believe that there is such a relation; if anything my hunch would be that the current PR provokes existing buggy behavior in libres - but I find also that quite hard to believe.

A bit tight now; but I can assist in debugging this tomorrow.

@andreabrambilla
Copy link
Contributor

I agree it's absurd, but I am sure it's triggered by this (directly or indirectly). I have created a custom branch with this commit reverted, and built libres against that, and all the tests passed.

The osx image we use in the libres build is quite outdated (I think there was a reason for that, but can't remember now). I'll try updating it and see if the issue disappears

@andreabrambilla
Copy link
Contributor

Ok, updating the osx image worked, sorry for bothering you!

@joakim-hove
Copy link
Contributor Author

joakim-hove commented Aug 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants