#3846 - macro class field is absent after serialisation to ket #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved logic into ketSerializer - removed line - updated solution / - fixed tests, snapshots - created mapper returned back .mol / .ket files - changed name - changed function - added monomerFactory instead of custom function - removed old function - removed extra types - updated snapshots
Zhirnoff
approved these changes
Jan 18, 2024
|
@Konstantin1996 PR is not linked with the issue |
rrodionov91
approved these changes
Jan 18, 2024
rrodionov91
deleted the
3846-macro-class-field-is-absent-after-serialisation-to-ket-release/2.18
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
closes #3846 (comment)
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name