Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #3846 - macro class field is absent after serialisation to ket #3859

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Backmerge: #3846 - macro class field is absent after serialisation to ket #3859

merged 11 commits into from
Jan 15, 2024

Conversation

Konstantin1996
Copy link
Collaborator

@Konstantin1996 Konstantin1996 commented Jan 10, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

closes #3846 (comment)

  • added MonomerClass for monomers

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@Konstantin1996 Konstantin1996 marked this pull request as ready for review January 11, 2024 12:22
@Konstantin1996 Konstantin1996 force-pushed the 3846-macro-class-field-is-absent-after-serialisation-to-ket branch 2 times, most recently from 51a8e60 to eb77dee Compare January 12, 2024 11:42
@Konstantin1996 Konstantin1996 force-pushed the 3846-macro-class-field-is-absent-after-serialisation-to-ket branch from eb77dee to fced5ab Compare January 12, 2024 13:47
@rrodionov91 rrodionov91 merged commit 5292ada into master Jan 15, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 3846-macro-class-field-is-absent-after-serialisation-to-ket branch January 15, 2024 11:48
@Konstantin1996 Konstantin1996 mentioned this pull request Jan 18, 2024
Merged
9 tasks
@rrodionov91 rrodionov91 changed the title #3846 - macro class field is absent after serialisation to ket Backmerge: #3846 - macro class field is absent after serialisation to ket Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 approved these changes

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@Konstantin1996 Konstantin1996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro: 'class' field is absent after serialisation to ket
2 participants
@Konstantin1996 @rrodionov91