Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: 'class' field is absent after serialisation to ket #3846

Closed
rrodionov91 opened this issue Jan 5, 2024 · 1 comment · Fixed by #3859 or #3930
Closed

Macro: 'class' field is absent after serialisation to ket #3846

rrodionov91 opened this issue Jan 5, 2024 · 1 comment · Fixed by #3859 or #3930
Assignees
@Konstantin1996
Labels
bug
Milestone
Ketcher 2.18.0-rc.3

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode
  2. Add any Sugar to canvas
  3. Save to ket file

Actual behavior
Field class is absent in ket file.

Expected behavior
Fields "classHELM" and "class" contain values according to specification https://kb.epam.com/display/EPMLSOP/KET+specification+for+macromolecules
Field "classHELM" contains value PEPTIDE/RNA/CHEM.
Field "class" contains value AminoAcid/Sugar/Phosphate/Base/Terminator/Linker/Unknown/CHEM.
@rrodionov91 rrodionov91 added the bug label Jan 5, 2024
@rrodionov91 rrodionov91 added this to the Macromolecules Milestone 4 milestone Jan 5, 2024
@rrodionov91 rrodionov91 changed the title Macro: classHELM field should contain concrete monomer type after serialisation to ket Macro: 'class' field should contains is absent after serialisation to ket Jan 5, 2024
@Nitvex Nitvex changed the title Macro: 'class' field should contains is absent after serialisation to ket Macro: 'class' field is absent after serialisation to ket Jan 8, 2024
@Nitvex Nitvex assigned Konstantin1996 and unassigned Nitvex Jan 9, 2024
@Konstantin1996 Konstantin1996 mentioned this issue Jan 10, 2024
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 15, 2024
@Konstantin1996
#3846 - macro class field is absent after serialisation to ket (#3859)
5292ada 
Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
@Konstantin1996 Konstantin1996 mentioned this issue Jan 18, 2024
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Jan 18, 2024 that will close this issue
#3846 - macro class field is absent after serialisation to ket #3930
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 18, 2024
@Konstantin1996
#3846 - macro class field is absent after serialisation to ket
116430c 
Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
@Zhirnoff
Copy link
Collaborator

Tests added to the automation table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Konstantin1996 Konstantin1996

Labels
bug
Projects
None yet
Milestone
Ketcher 2.18.0-rc.3
4 participants
@rrodionov91 @Konstantin1996 @Nitvex @Zhirnoff