#2585 Change behaviour of "Show hydrogen labels" setting so the "on" value works the same way as "terminal and hetero" #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value works the same way as "terminal and hetero"
|
Had to re-open the pull request, code was updated for new requirements |
|
Currently the schema will reset to default value if the provided one is not in the enum. So users who have "on" in the saved settings will have the value set to default from the schema, which is "Terminal and Hetero" at the moment. |
|
Looks good |
gairon
approved these changes
May 9, 2023
KonstantinEpam23
deleted the
2585-change-behaviour-of-show-hydrogen-labels-setting-so-the-on-value-works-the-same-way-as-terminal-and-hetero-210
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.