You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Background
In previous versions the "ON" setting for "Show hydrogen labels" did not work correctly (worked the same way "Terminal and Hetero" should work) As part of #2245 the behaviour for "ON" option was fixed, but it was previously selected as default behaviour, so all users who have updated any settings in the previous versions will have this setting set to "ON", while the default should be "Terminal and Hetero"
Actual behavior
When the setting is "ON" all atoms show labels and hydrogens
Expected behavior
When setting is "ON" it should show labels and hydrogens only for terminal and hetero atoms (same as "Terminal and Hetero" option works now)
Option "ALL" is added that makes it show labels and hydrogens for all atoms.
Proposed solution
All current options for "Show hydrogen labels" work the same way as they do now, except for "On" option
"On" option is saved as "all" when settings are updated
If the user has "on" value in the saved settings - interpret it as "Terminal and Hetero" option
Ketcher version
v2.10.0-rc.2
The text was updated successfully, but these errors were encountered:
KonstantinEpam23
changed the title
Change behaviour of "Show hydrogen labels" setting so the default value works correctly
Change behaviour of "Show hydrogen labels" setting so the "on" value works the same way as "terminal and hetero"
May 9, 2023
Background
In previous versions the "ON" setting for "Show hydrogen labels" did not work correctly (worked the same way "Terminal and Hetero" should work) As part of #2245 the behaviour for "ON" option was fixed, but it was previously selected as default behaviour, so all users who have updated any settings in the previous versions will have this setting set to "ON", while the default should be "Terminal and Hetero"
Actual behavior
When the setting is "ON" all atoms show labels and hydrogens
Expected behavior
When setting is "ON" it should show labels and hydrogens only for terminal and hetero atoms (same as "Terminal and Hetero" option works now)
Option "ALL" is added that makes it show labels and hydrogens for all atoms.
Proposed solution
Ketcher version
v2.10.0-rc.2
The text was updated successfully, but these errors were encountered: