Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of "Show hydrogen labels" setting so the "on" value works the same way as "terminal and hetero" #2585

Closed
KonstantinEpam23 opened this issue May 9, 2023 · 0 comments · Fixed by #2588 or #2589

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented May 9, 2023

Background
In previous versions the "ON" setting for "Show hydrogen labels" did not work correctly (worked the same way "Terminal and Hetero" should work) As part of #2245 the behaviour for "ON" option was fixed, but it was previously selected as default behaviour, so all users who have updated any settings in the previous versions will have this setting set to "ON", while the default should be "Terminal and Hetero"

Actual behavior
When the setting is "ON" all atoms show labels and hydrogens

Expected behavior
When setting is "ON" it should show labels and hydrogens only for terminal and hetero atoms (same as "Terminal and Hetero" option works now)
Option "ALL" is added that makes it show labels and hydrogens for all atoms.

Proposed solution

  1. All current options for "Show hydrogen labels" work the same way as they do now, except for "On" option
  2. "On" option is saved as "all" when settings are updated
  3. If the user has "on" value in the saved settings - interpret it as "Terminal and Hetero" option

Ketcher version
v2.10.0-rc.2

@KonstantinEpam23 KonstantinEpam23 added this to the Ketcher 2.10.0-rc.3 milestone May 9, 2023
@KonstantinEpam23 KonstantinEpam23 self-assigned this May 9, 2023
@KonstantinEpam23 KonstantinEpam23 changed the title Change behaviour of "Show hydrogen labels" setting so the default value works correctly Change behaviour of "Show hydrogen labels" setting so the "on" value works the same way as "terminal and hetero" May 9, 2023
KonstantinEpam23 added a commit that referenced this issue May 9, 2023
…value works the same way as "terminal and hetero"
KonstantinEpam23 added a commit that referenced this issue May 9, 2023
…value works the same way as "terminal and hetero" (#2588)
KonstantinEpam23 added a commit that referenced this issue May 9, 2023
…value works the same way as "terminal and hetero"
KonstantinEpam23 added a commit that referenced this issue May 9, 2023
…value works the same way as "terminal and hetero" (#2589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment