Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2585 Change behaviour of "Show hydrogen labels" setting so the "on" value works the same way as "terminal and hetero" #2588

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/ketcher-core/src/application/render/restruct/reatom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,15 @@ export enum ShowHydrogenLabels {
Hetero = 'Hetero',
Terminal = 'Terminal',
TerminalAndHetero = 'Terminal and Hetero',
On = 'on'
On = 'all'
}

export enum ShowHydrogenLabelNames {
Off = 'Off',
Hetero = 'Hetero',
Terminal = 'Terminal',
TerminalAndHetero = 'Terminal and Hetero',
On = 'On'
}

class ReAtom extends ReObject {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
import {
StereLabelStyleType,
StereoColoringType,
ShowHydrogenLabels
ShowHydrogenLabels,
ShowHydrogenLabelNames
} from 'ketcher-core'
import Ajv, { SchemaObject } from 'ajv'

Expand Down Expand Up @@ -200,6 +201,7 @@ const render: {
showHydrogenLabels: {
title: 'Show hydrogen labels',
enum: Object.values(ShowHydrogenLabels),
enumNames: Object.values(ShowHydrogenLabelNames),
default: ShowHydrogenLabels.TerminalAndHetero
},
// Bonds
Expand Down