Change container distro to Debian and Ubuntu to avoid runtime errors. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the container's distribution to Debian for building and to Ubuntu for final distribution, because this more closely matches upstream Substrate's build pipeline and seems to more reliably avoid runtime issues caused by missing shared libraries and the like. We also no longer compile statically, for now, as it's not needed in this setup, and we try to maintain a smaller container image size by installing only required packages and components of the Rust toolchain. In my testing, this creates image sizes of just about ~200MB, which is not terrible but not ideal (previous image sizes were down to ~60MB). Nevertheless, as this also unblocks `entropy-js`, I think it's worth it.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like Vercel is failing because of an expired credential, FYI. |
HCastano
approved these changes
Nov 7, 2023
ameba23
added a commit
that referenced
this pull request
Nov 9, 2023
* master: Update README to include new Docker Compose instructions. (#482) Change container distro to Debian and Ubuntu to avoid runtime errors. (#481) Remove old Docker related script (#478) Release `v0.0.8` (#471) Add `prune_registration` extrinsic (#472) standard formatting + lil fixes (#477) Revert nightly changes to format script (#470) Add way for validators to resolve diff verifying keys (#460) Fix socket addres type (#469) Reduce `authoring_version` and add `RuntimeVersion` comments (#467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches the container's distribution to Debian for building and to Ubuntu for final distribution, because this more closely matches upstream Substrate's build pipeline and seems to more reliably avoid runtime issues caused by missing shared libraries and the like. We also no longer compile statically, for now, as it's not needed in this setup, and we try to maintain a smaller container image size by installing only required packages and components of the Rust toolchain.
In my testing, this creates image sizes of just about ~200MB, which is not terrible but not ideal (previous image sizes were down to ~60MB). Nevertheless, as this also unblocks
entropy-js, I think it's worth it.