Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.0.8 #471

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Release v0.0.8 #471

merged 12 commits into from
Nov 6, 2023

Conversation

HCastano
Copy link
Collaborator

@HCastano HCastano commented Nov 2, 2023

This PR gets everything in line for the v0.0.8 release.

During this some questions have come up for me regarding the release flow. We don't need
to answer all of these now, but we should at least keep them in mind:

  • How do we want to manage versions for published crates? Do we want to make each crate
    follow it's on SemVer, or publish as a workspace (so all published crates have the same
    version number)?
    • I didn't bump any of the SemVer versions in this release, gonna think about it more
  • Similarly, can we restructure the repo a bit to make it more clear what we're going to
    publish vs. keep private?
    • Maybe a script enumerating all the to-be-released crates would be enough though
  • For benchmarking, do we need both the runtime and pallet weight.rs files?
    • I think there is a case for both, but I don't remember what the distiction here is
      tbh

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 8:56pm

@HCastano
Copy link
Collaborator Author

HCastano commented Nov 2, 2023

(I want to do some testing on the build artifacts before merging this)

ameba23
ameba23 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

Also very good points for discussion about publishing and versioning.

Re: whether to publish all crates under the same version number, i can see good arguments for and against, need to think about it more.

@HCastano HCastano merged commit 97138a5 into master Nov 6, 2023
5 checks passed
@HCastano HCastano deleted the hc-release-v0.0.8 branch November 6, 2023 20:57
ameba23 added a commit that referenced this pull request Nov 9, 2023
@ameba23
Merge branch 'master' into subxt-client
ed03081 
* master:
  Update README to include new Docker Compose instructions. (#482)
  Change container distro to Debian and Ubuntu to avoid runtime errors. (#481)
  Remove old Docker related script (#478)
  Release `v0.0.8` (#471)
  Add `prune_registration` extrinsic (#472)
  standard formatting + lil fixes (#477)
  Revert nightly changes to format script (#470)
  Add way for validators to resolve diff verifying keys (#460)
  Fix socket addres type (#469)
  Reduce `authoring_version` and add `RuntimeVersion` comments (#467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameba23 ameba23 ameba23 approved these changes

@JesseAbram JesseAbram JesseAbram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HCastano @ameba23 @JesseAbram