-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prune_registration
extrinsic
#472
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prune_registration
extrinsic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the PruneBlock
usage.
should anyone be able to unregister an account, in all successful scenarios an account should be registered and if it fails as long as the prune block passes then clearly dkg has failed and why does it matter who unregisters
I'm gonna say in the future maybe, but for now no. We're taking storage deposits and stuff anyways so it's not a huge deal to have these accounts hanging around.
We also don't do any actual pruning right now, but that's a piece of functionality we can build out later
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
this would stop a user from retrying register which would essentially burn that sig_request key on entropy |
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things need to be addressed, but once those are done feel free to merge 👍
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
* master: Update README to include new Docker Compose instructions. (#482) Change container distro to Debian and Ubuntu to avoid runtime errors. (#481) Remove old Docker related script (#478) Release `v0.0.8` (#471) Add `prune_registration` extrinsic (#472) standard formatting + lil fixes (#477) Revert nightly changes to format script (#470) Add way for validators to resolve diff verifying keys (#460) Fix socket addres type (#469) Reduce `authoring_version` and add `RuntimeVersion` comments (#467)
Currently if the dkg process were to fail the account would be stuck in a registering state indefinetly
this gives us an extrinsic to unregister so an account can re-register if an amount of blocks has passed
Open questions
#457