Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prune_registration extrinsic #472

Merged
merged 14 commits into from
Nov 4, 2023
Merged

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Nov 2, 2023

Currently if the dkg process were to fail the account would be stuck in a registering state indefinetly

this gives us an extrinsic to unregister so an account can re-register if an amount of blocks has passed

Open questions

  • should anyone be able to unregister an account, in all successful scenarios an account should be registered and if it fails as long as the prune block passes then clearly dkg has failed and why does it matter who unregisters

#457

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:32am

@HCastano HCastano changed the title add prune registration extrinsic Add prune_registration extrinsic Nov 3, 2023
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the PruneBlock usage.

should anyone be able to unregister an account, in all successful scenarios an account should be registered and if it fails as long as the prune block passes then clearly dkg has failed and why does it matter who unregisters

I'm gonna say in the future maybe, but for now no. We're taking storage deposits and stuff anyways so it's not a huge deal to have these accounts hanging around.

We also don't do any actual pruning right now, but that's a piece of functionality we can build out later

CHANGELOG.md Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
scripts/benchmarks.sh Show resolved Hide resolved
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
@JesseAbram
Copy link
Member Author

I'm gonna say in the future maybe, but for now no. We're taking storage deposits and stuff anyways so it's not a huge deal to have these accounts hanging around.

this would stop a user from retrying register which would essentially burn that sig_request key on entropy

@JesseAbram JesseAbram requested a review from HCastano November 3, 2023 20:29
CHANGELOG.md Outdated Show resolved Hide resolved
scripts/benchmarks.sh Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
JesseAbram and others added 3 commits November 3, 2023 17:16
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things need to be addressed, but once those are done feel free to merge 👍

pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
JesseAbram and others added 4 commits November 3, 2023 16:46
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
@JesseAbram JesseAbram merged commit 5ea3ba1 into master Nov 4, 2023
5 checks passed
@JesseAbram JesseAbram deleted the failed-registration-recovery branch November 4, 2023 01:42
ameba23 added a commit that referenced this pull request Nov 9, 2023
* master:
  Update README to include new Docker Compose instructions. (#482)
  Change container distro to Debian and Ubuntu to avoid runtime errors. (#481)
  Remove old Docker related script (#478)
  Release `v0.0.8` (#471)
  Add `prune_registration` extrinsic (#472)
  standard formatting + lil fixes (#477)
  Revert nightly changes to format script (#470)
  Add way for validators to resolve diff verifying keys (#460)
  Fix socket addres type (#469)
  Reduce `authoring_version` and add `RuntimeVersion` comments (#467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants