chore(ses): Reapply hardened typed array configurable properties test #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-test-hardened-typed-array-configurability-1045
branch
from
622eaf4 to
a0568e5
Compare
kriskowal
deleted the
kriskowal-test-hardened-typed-array-configurability-1045
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053
Description
A defect in a version of Node 14 required us to relax a check in the SES tests. With Node.js 14 a distant memory and 18 being LTS, we can reapply the test.
Security Considerations
This reenables a test of our invariants.
Scaling Considerations
Not applicable.
Documentation Considerations
None.
Testing Considerations
Improves tests.
Compatibility Considerations
Does not alter compatibility.
Upgrade Considerations
Will not impact upgrade.