Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ses): Reapply hardened typed array configurable properties test #2019

Merged
merged 1 commit into from
Jan 30, 2024
Merged

chore(ses): Reapply hardened typed array configurable properties test #2019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/ses/test/test-make-hardener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ test('harden typed arrays', t => {
t.truthy(Object.isSealed(a));
const descriptor = Object.getOwnPropertyDescriptor(a, '0');
t.is(descriptor.value, a[0]);
// Fails in Node.js 14 and earlier due to an engine bug:
// t.is(descriptor.configurable, true, 'hardened typed array indexed property remains configurable');
// Failed in Node.js 14 and earlier due to an engine bug:
t.is(
descriptor.configurable,
true,
'hardened typed array indexed property remains configurable',
);
// Note that indexes of typed arrays are exceptionally writable for hardened objects.
t.is(
descriptor.writable,
Expand Down Expand Up @@ -187,8 +191,12 @@ test('harden typed arrays and their expandos', t => {
{ value: 0, writable: true, enumerable: true },
'hardened typed array index property',
);
// Fails in Node.js 14 and earlier due to an engine bug:
// t.is(descriptor.configurable, true, 'typed array indexed property is configurable');
// Failed in Node.js 14 and earlier due to an engine bug:
t.is(
descriptor.configurable,
true,
'typed array indexed property is configurable',
);
// Note that indexes of typed arrays are exceptionally writable for hardened objects:
}

Expand Down
Loading