Skip to content

Commit

Permalink
chore(ses): Reapply hardened typed array configurable properties test…
Browse files Browse the repository at this point in the history
… (merge #2019)
  • Loading branch information
kriskowal authored Jan 30, 2024
2 parents 4040f0e + a0568e5 commit 163880e
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions packages/ses/test/test-make-hardener.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ test('harden typed arrays', t => {
t.truthy(Object.isSealed(a));
const descriptor = Object.getOwnPropertyDescriptor(a, '0');
t.is(descriptor.value, a[0]);
// Fails in Node.js 14 and earlier due to an engine bug:
// t.is(descriptor.configurable, true, 'hardened typed array indexed property remains configurable');
// Failed in Node.js 14 and earlier due to an engine bug:
t.is(
descriptor.configurable,
true,
'hardened typed array indexed property remains configurable',
);
// Note that indexes of typed arrays are exceptionally writable for hardened objects.
t.is(
descriptor.writable,
Expand Down Expand Up @@ -187,8 +191,12 @@ test('harden typed arrays and their expandos', t => {
{ value: 0, writable: true, enumerable: true },
'hardened typed array index property',
);
// Fails in Node.js 14 and earlier due to an engine bug:
// t.is(descriptor.configurable, true, 'typed array indexed property is configurable');
// Failed in Node.js 14 and earlier due to an engine bug:
t.is(
descriptor.configurable,
true,
'typed array indexed property is configurable',
);
// Note that indexes of typed arrays are exceptionally writable for hardened objects:
}

Expand Down

0 comments on commit 163880e

Please sign in to comment.