Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view destruction inside outlets #11577

Merged
merged 2 commits into from
Jun 29, 2015
Merged

Fix view destruction inside outlets #11577

merged 2 commits into from
Jun 29, 2015

Commits on Jun 28, 2015

  1. Added failing test for emberjs#11539

    @ef4
    ef4 committed Jun 28, 2015
    Configuration menu
    Copy the full SHA
    78d0306 View commit details
    Browse the repository at this point in the history

  2. Fix view destruction inside outlets 

    This solution feels hacky and we need to discuss what code is really
responsible for view destruction. The htmlbars code that clears the DOM
does not do view destruction, which leaves us in an awkward situation
where the DOM is already removed but we need to destroy the view.
    @ef4
    ef4 committed Jun 28, 2015
    Configuration menu
    Copy the full SHA
    1fc7811 View commit details
    Browse the repository at this point in the history