Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember 1.13.1]willDestroyElement never called #11539

Closed
patricklx opened this issue Jun 23, 2015 · 12 comments · Fixed by #11577
Closed

[Ember 1.13.1]willDestroyElement never called #11539

patricklx opened this issue Jun 23, 2015 · 12 comments · Fixed by #11577
Assignees

Comments

@patricklx
Copy link
Contributor

I know the view is deprecated, but shouldnt this still work anyway?

here is a jsbin showing the issue, just change to 1.12.1 to see it work
http://emberjs.jsbin.com/puconuxita/edit?html,css,js,console,output

@berdof
Copy link

berdof commented Jun 24, 2015

Ember 1.13.2 bumped into the same issue

@caseyjenks
Copy link

same issue. anybody have any luck?

@rwjblue
Copy link
Member

rwjblue commented Jun 25, 2015

Updated JSBin: http://emberjs.jsbin.com/pijebi/edit?html,js,console,output

It doesn't seem like route backing views are actually destroyed at all.

@dfreeman
Copy link
Contributor

Also running into this; it's blocking our upgrade to 1.13 :(

@berdof
Copy link

berdof commented Jun 26, 2015

Any workaround or hotfixes?

@ef4 ef4 self-assigned this Jun 26, 2015
ef4 added a commit to ef4/ember.js that referenced this issue Jun 28, 2015
ef4 added a commit that referenced this issue Jun 30, 2015
(cherry picked from commit 78d0306)
ef4 added a commit that referenced this issue Jul 1, 2015
(cherry picked from commit 78d0306)
(cherry picked from commit fb883c4)
@BlakeWilliams
Copy link
Contributor

Since this breaks compatibility, can we get a point release for this?

@rwjblue
Copy link
Member

rwjblue commented Jul 2, 2015

The fix for this is already in the stable branch, and will be included in 1.13.3.

@BlakeWilliams
Copy link
Contributor

Thanks for letting me know, looking forward to 1.13.3. 😃

@jcbvm
Copy link

jcbvm commented Jul 4, 2015

Is there a release date for 1.13.3? I'm waiting for this fix to move some code to production, preferably next week.

@stefanpenner
Copy link
Member

Is there a release date for 1.13.3? I'm waiting for this fix to move some code to production, preferably next week.

typically we do a weekly release, there is a good chance towards the end of this weekend / early this week.

@rwjblue
Copy link
Member

rwjblue commented Jul 4, 2015 via email

@jcbvm
Copy link

jcbvm commented Jul 5, 2015

Thanks

ef4 added a commit that referenced this issue Jul 5, 2015
(cherry picked from commit 78d0306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants