Fix view destruction inside outlets #11577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution feels hacky and we need to discuss what code is really responsible for view destruction. The htmlbars code that clears the DOM does not do view destruction, which leaves us in an awkward situation where the DOM is already removed but we need to destroy the view.
| @@ -210,7 +210,7 @@ Renderer.prototype.renderElementRemoval = | |||
| if (view._willRemoveElement) { | |||
| view._willRemoveElement = false; | |||
|
|
|||
| if (view._renderNode) { | |||
| if (view._renderNode && view.element && view.element.parentNode) { | |||
There was a problem hiding this comment.
This is the especially hacky bit. Without this, views that are already out-of-DOM will delete unrelated subsequent content that has replaced them in the same render node.
|
Despite my above caveats, I do think this code is safe to merge and it solves a pressing issue that is blocking people's upgrades. We can address the architectural concern at our leisure. |
rwjblue
added a commit
that referenced
this pull request
Jun 29, 2015
Fix view destruction inside outlets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11539. However, I think it's hacky and this needs review by @wycats and maybe @mmun.
I do not see who is truly responsible for view destruction. HTMLBars is clearing the DOM nodes without destroying corresponding views. This leaves a keyword like
outletin an awkward position of needing to destroy views that are already out-of-DOM, which is bad because the views will blindly nuke their original contextual element even though subsequent content may already be present.