Release 1.7.12 #429

vildead · 2023-07-20T12:42:50Z

Tested on DAISY stable. Migration went successfully without errors.

…e by one

…t-access Changing behavior for editing accesses

bumb version to 1.7.11

Create docker-image.yml to automate building and publishing the docker image

Bumps [django](https://github.com/django/django) from 3.2 to 3.2.18. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.2...3.2.18) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…3.2.18 Bump django from 3.2 to 3.2.18

Bumps [django-debug-toolbar](https://github.com/jazzband/django-debug-toolbar) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/jazzband/django-debug-toolbar/releases) - [Changelog](https://github.com/jazzband/django-debug-toolbar/blob/main/docs/changes.rst) - [Commits](jazzband/django-debug-toolbar@3.2...3.2.1) --- updated-dependencies: - dependency-name: django-debug-toolbar dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…debug-toolbar-3.2.1 Bump django-debug-toolbar from 3.2.0 to 3.2.1

…point publishing

…mplate.py accordingly

…ded dataset form_id to dataset metadata

…le list and removed already exposed endpoints from new exposure endpoint dropdown

Bumps [django](https://github.com/django/django) from 3.2.18 to 3.2.19. - [Commits](django/django@3.2.18...3.2.19) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…on exposures_list in dataset and project, while other entities retain 'is_publishes' field with getter and setter methods.

… and take the project ribbon off

…nd used it in dataset view

…page

…s-list #420-added form_name to exposures_list in dataset view and admin view

…blished migration and linked it to last migration on develop

#422-is-published-property

change label to published instead of avavailable

sonatype-lift · 2023-07-20T12:42:53Z

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

sonatype-lift · 2023-07-20T12:45:45Z

elixir_daisy/settings.py

@@ -31,7 +31,7 @@
 # See https://docs.djangoproject.com/en/2.0/howto/deployment/checklist/

 # SECURITY WARNING: keep the secret key used in production secret!
-SECRET_KEY = 'qe1lmt43v1n%66vibs0&0s9qw7i!xjs^!i#f#$t_7-r8n&=+sp'
+SECRET_KEY = 'qe1lmt43v1n%66vibs0&0s9qw7i!xjs^!i#f#&t_7-r8n&=+sp'


B105: Possible hardcoded password: 'qe1lmt43v1n%66vibs0&0s9qw7i!xjs^!i#f#&t_7-r8n&=+sp'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:47Z

core/migrations/0032_auto_20230508_1200.py

+        migrations.AlterField(
+            model_name='endpoint',
+            name='api_key',
+            field=core.models.utils.HashedField(help_text="\n        * Please specify the API key to the endpoint, \n        head <a href='https://generate-random.org/api-key-generator?count=1&length=64&type=mixed-numbers&prefix=' target='_blank'> here </a>\n        to generate a random key and keep it somewhere, we only store a hash.\n        ", max_length=128, unique=True, verbose_name='API Key'),


E501: line too long (402 > 160 characters)

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

core/migrations/0032_auto_20230508_1200.py 22

core/migrations/0033_auto_20230515_1147.py 22

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:49Z

core/migrations/0034_auto_20230515_1353.py

@@ -0,0 +1,32 @@
+# Generated by Django 3.2.19 on 2023-05-15 11:53
+
+import core.models.utils


F401: 'core.models.utils' imported but unused

❗❗ 4 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

web/views/api.py 23

web/views/api.py 23

web/views/api.py 23

web/views/projects.py 3

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:51Z

core/models/exposure.py

+                                   on_delete=models.SET_NULL,
+                                   null=True,
+                                   help_text='Which User added this entry to DAISY', )
+


W293: blank line contains whitespace

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:53Z

core/models/project.py

@@ -151,7 +151,9 @@ def __str__(self):
        return self.acronym or self.title or "undefined"


-
+    @property


E303: too many blank lines (2)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:55Z

core/models/utils.py

 def validate_json(value):
    if len(value) == 0:
        return value

    try:
        loads(value)
        if '{' not in value:  # Very inaccurate, but should do the trick when the user tries to save e.g. '123'
-            raise ValidationError(f'`scientific_metadata` field must be a valid JSON containing a dictionary!')    
+            raise ValidationError(f'`scientific_metadata` field must be a valid JSON containing a dictionary!')


F541: f-string is missing placeholders

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:56Z

web/admin.py

+        return False
+
+@admin.register(Exposure)


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:45:58Z

core/forms/endpoint.py

@@ -0,0 +1,12 @@
+from django import forms


E0401: Unable to import 'django'

❗❗ 28 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

core/forms/exposure.py 1

core/migrations/0031_endpoint_exposure.py 4

core/migrations/0031_endpoint_exposure.py 5

core/migrations/0031_endpoint_exposure.py 6

core/migrations/0032_auto_20230508_1200.py 4

core/migrations/0033_auto_20230515_1147.py 4

core/migrations/0034_auto_20230515_1353.py 4

core/models/access.py 6

core/models/dataset.py 6

core/models/endpoint.py 3

Showing 10 of 28 findings. Visit the Lift Web Console to see all.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:46:00Z

core/forms/endpoint.py

@@ -0,0 +1,12 @@
+from django import forms


reportMissingImports: Import "django" could not be resolved

❗❗ 28 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

core/forms/exposure.py 1

core/migrations/0031_endpoint_exposure.py 4

core/migrations/0031_endpoint_exposure.py 5

core/migrations/0031_endpoint_exposure.py 6

core/migrations/0032_auto_20230508_1200.py 4

core/migrations/0033_auto_20230515_1147.py 4

core/migrations/0034_auto_20230515_1353.py 4

core/models/access.py 6

core/models/dataset.py 6

core/models/endpoint.py 3

Showing 10 of 28 findings. Visit the Lift Web Console to see all.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-20T12:46:02Z

core/forms/exposure.py

+        exposure_list = Exposure.objects.filter(dataset=dataset)
+        endpoint_ids = exposure_list.values_list('endpoint', flat=True)
+        self.fields['endpoint'].choices = [(e.id, e) for e in Endpoint.objects.exclude(id__in=endpoint_ids)] + \
+                                          [(endpoint.id, endpoint)]


reportOptionalMemberAccess: "id" is not a known member of "None"

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

web/views/exposure.py 48

web/views/exposure.py 58

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

1 7 12 resolve conflict

Fancien and others added 30 commits January 19, 2023 15:57

Updating permissions on Access objects

b4a546c

Returning error if non-datastewards tries to edit an active Access

9d04f50

Removing error message on new submit

b951349

Correcting a validation check and displaying all errors instead of on…

104c89d

…e by one

Merge pull request #404 from elixir-luxembourg/bugfix-permissions-edi…

0857fd4

…t-access Changing behavior for editing accesses

bumb version to 1.7.11

c51a15f

Merge pull request #405 from elixir-luxembourg/bump-version-to-1.7.11

02ba0ac

bumb version to 1.7.11

Create docker-image.yml

060fa34

remove triggering the workflow on PRs

4f110a3

Merge pull request #409 from elixir-luxembourg/add-docker-build-action

fd3bf7c

Create docker-image.yml to automate building and publishing the docker image

Merge pull request #410 from elixir-luxembourg/dependabot/pip/django-…

4e950fd

…3.2.18 Bump django from 3.2 to 3.2.18

Merge pull request #411 from elixir-luxembourg/dependabot/pip/django-…

d7c7cbd

…debug-toolbar-3.2.1 Bump django-debug-toolbar from 3.2.0 to 3.2.1

#412 - create models endpoint and exposure to enable the multiple end…

3db3d0e

…point publishing

fix linting issues

83287a3

more linting

1151100

some more linting

b4eff4d

added exposure UI, form, views. updates urls.py and settings_local.te…

e628c78

…mplate.py accordingly

removed publish and unpublish ribbons and buttons from dataset and ad…

7dae6ab

…ded dataset form_id to dataset metadata

removed export form_id form dataset to be fixed later

1d57bb6

removing unnecessary migration

5ee8b23

added endpoints links to dataset description and updated exposure tab…

84a5a8c

…le list and removed already exposed endpoints from new exposure endpoint dropdown

change dataset export api to use endpoints

5afaed5

replace url patterns with the actual entity id

2ff7232

fix previous tests

b4e0996

change flake8 max length for line

2b5f30c

[Lint] apply sonatype suggestions

be376bb

add tests specific to the dataset and project api

1d068ad

nirmeen and others added 16 commits May 15, 2023 13:01

added form_name to exposures_list in dataset view and admin view

8ad5ad9

Refactor 'is_published' field as abstract method and define it based …

4d293a5

…on exposures_list in dataset and project, while other entities retain 'is_publishes' field with getter and setter methods.

refactor the whole code base to align with the new is_published logic…

aec1bf8

… and take the project ribbon off

add filter to exposure admin model

167132b

refactored publish method as an abstract method in coretrackedmodel a…

b89e528

…nd used it in dataset view

created a readonly admin to view exposures list as readonly in admin …

a2e433b

…page

added generate_elu_accession to publish in dataset model

2fcfa37

removed form_id from exposure admin filter_list

0a0d631

Merge pull request #421 from elixir-luxembourg/420-form-name-exposure…

17cd482

…s-list #420-added form_name to exposures_list in dataset view and admin view

saved dataset on exposure delete to trigger reindex and renamed is_pu…

dc2a851

…blished migration and linked it to last migration on develop

Merge pull request #423 from elixir-luxembourg/422-is-published-property

ce6c83a

#422-is-published-property

change label to published instead of avavailable

efeae8c

Merge pull request #424 from elixir-luxembourg/fix/change-publish-label

3903535

change label to published instead of avavailable

fix redering of special subject attribute on data declarion overview

b0c49e0

bump version to 1.7.2

a8890ef

bump version to 1.7.12

72a3639

resolving conflict with master

a1c962a

sonatype-lift bot reviewed Jul 20, 2023

View reviewed changes

Merge pull request #430 from elixir-luxembourg/1-7-12-resolve-conflict

f4b41df

1 7 12 resolve conflict

vildead merged commit b75bcc2 into master Jul 20, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.7.12 #429

Release 1.7.12 #429

vildead commented Jul 20, 2023

sonatype-lift bot commented Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

sonatype-lift bot Jul 20, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

File Path	Line Number
core/migrations/0032_auto_20230508_1200.py	22
core/migrations/0033_auto_20230515_1147.py	22

		@@ -0,0 +1,32 @@
		# Generated by Django 3.2.19 on 2023-05-15 11:53

		import core.models.utils

File Path	Line Number
web/views/api.py	23
web/views/api.py	23
web/views/api.py	23
web/views/projects.py	3

		@@ -151,7 +151,9 @@ def __str__(self):
		return self.acronym or self.title or "undefined"



		@property

File Path	Line Number
core/forms/exposure.py	1
core/migrations/0031_endpoint_exposure.py	4
core/migrations/0031_endpoint_exposure.py	5
core/migrations/0031_endpoint_exposure.py	6
core/migrations/0032_auto_20230508_1200.py	4
core/migrations/0033_auto_20230515_1147.py	4
core/migrations/0034_auto_20230515_1353.py	4
core/models/access.py	6
core/models/dataset.py	6
core/models/endpoint.py	3

Release 1.7.12 #429

Release 1.7.12 #429

Conversation

vildead commented Jul 20, 2023

sonatype-lift bot commented Jul 20, 2023

Sonatype Lift is retiring

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 20, 2023

Choose a reason for hiding this comment