Changing behavior for editing accesses #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HesamKorki
approved these changes
Jan 20, 2023
vildead
reviewed
Jan 20, 2023
| @@ -89,13 +90,19 @@ class AccessEditView(CheckerMixin, UpdateView, AjaxViewMixin): | |||
| permission_target = 'dataset' | |||
|
|
|||
| def form_valid(self, form): | |||
| """If access status is Active, only data stewards can edit it""" | |||
| original_object = self.model.objects.get(pk=self.object.id) | |||
| if original_object.status == StatusChoices.active and not self.request.user.is_part_of(Groups.DATA_STEWARD.value): | |||
There was a problem hiding this comment.
isnt it the same validation as on line 102?
There was a problem hiding this comment.
ah. sorry. Now I see. First is the form as such, second is just status field ;)
|
works as a charm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the rules to edit accesses: