#422-is-published-property #423

nirmeen · 2023-05-15T12:17:00Z

Refactor 'is_published' field as abstract method and define it based on exposures_list in dataset and project, while other entities retain 'is_published' field with getter and setter methods.

…on exposures_list in dataset and project, while other entities retain 'is_publishes' field with getter and setter methods.

sonatype-lift · 2023-05-15T12:19:38Z

core/migrations/0033_auto_20230515_1353.py

@@ -0,0 +1,32 @@
+# Generated by Django 3.2.19 on 2023-05-15 11:53
+
+import core.models.utils


F401: 'core.models.utils' imported but unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:40Z

core/models/project.py

@@ -151,7 +151,9 @@ def __str__(self):
        return self.acronym or self.title or "undefined"


-
+    @property


E303: too many blank lines (2)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:41Z

core/models/utils.py

 def validate_json(value):
    if len(value) == 0:
        return value

    try:
        loads(value)
        if '{' not in value:  # Very inaccurate, but should do the trick when the user tries to save e.g. '123'
-            raise ValidationError(f'`scientific_metadata` field must be a valid JSON containing a dictionary!')    
+            raise ValidationError(f'`scientific_metadata` field must be a valid JSON containing a dictionary!')


F541: f-string is missing placeholders

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:43Z

core/models/utils.py

+
+    class Meta:
+        abstract = True
+    @property


E301: expected 1 blank line, found 0

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:45Z

core/migrations/0033_auto_20230515_1353.py

+# Generated by Django 3.2.19 on 2023-05-15 11:53
+
+import core.models.utils
+from django.db import migrations


E0401: Unable to import 'django.db'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:47Z

core/models/utils.py

    class Meta:
        abstract = True

+    @abstractmethod
+    def is_published(self):


E0202: An attribute defined in core.models.utils line 69 hides this method

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T12:19:48Z

core/migrations/0033_auto_20230515_1353.py

+# Generated by Django 3.2.19 on 2023-05-15 11:53
+
+import core.models.utils
+from django.db import migrations


reportMissingImports: Import "django.db" could not be resolved

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

… and take the project ribbon off

sonatype-lift · 2023-05-15T15:04:32Z

core/models/dataset.py

-        if self.project:
-            self.project.publish()
-
+    def publish(self):     


W291: trailing whitespace

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T15:04:34Z

web/views/projects.py

@@ -3,6 +3,7 @@
 from django.contrib.auth.decorators import user_passes_test


F401: 'django.contrib.auth.decorators.user_passes_test' imported but unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T15:04:36Z

core/models/access.py

@@ -3,7 +3,7 @@

 from django.core.exceptions import ValidationError
 from django.db import models
-from django.db.models import Q, ObjectDoesNotExist
+from django.db.models import Q, ObjectDoesNotExist, Count


E0401: Unable to import 'django.db.models'

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

web/views/api.py 14

web/views/projects.py 6

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-15T15:04:38Z

core/models/access.py

@@ -3,7 +3,7 @@

 from django.core.exceptions import ValidationError
 from django.db import models
-from django.db.models import Q, ObjectDoesNotExist
+from django.db.models import Q, ObjectDoesNotExist, Count


reportMissingImports: Import "django.db.models" could not be resolved

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

web/views/api.py 14

web/views/projects.py 6

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Fancien · 2023-05-16T07:07:21Z

core/migrations/0033_auto_20230515_1353.py

Careful to change migration name and dependency once #420 is merged in develop

…nd used it in dataset view

sonatype-lift · 2023-05-16T12:33:38Z

web/views/exposure.py

@@ -41,6 +43,8 @@ def form_valid(self, form):
        self.object.save()
        messages.add_message(self.request, messages.SUCCESS, 'exposure endpoint created')
        self.dataset.generate_elu_accession()
+        # publish subentities
+        self.dataset.publish()


reportOptionalMemberAccess: "publish" is not a known member of "None"

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

neoflex · 2023-05-16T13:57:18Z

web/views/exposure.py

        self.dataset.generate_elu_accession()
+        # publish subentities
+        self.dataset.publish()


shouldn't we just put the call to self.dataset.generate_elu_accession() directly in dataset.publish to avoid having to call two functions and make sure the generate_elu_accession is always called with publish?

i felt then we need to rename the method because it is somehow different logic

I meant keeping the generate_elu_accession method, just calling it when we call publish. As we should never publish without assigning an elu accession id, for me, it makes sense, no?

yes, will make it as before then

core/models/dataset.py

…blished migration and linked it to last migration on develop

core/migrations/0034_auto_20230515_1353.py

Refactor 'is_published' field as abstract method and define it based …

4d293a5

…on exposures_list in dataset and project, while other entities retain 'is_publishes' field with getter and setter methods.

nirmeen added the wip Work In Progress label May 15, 2023

sonatype-lift bot reviewed May 15, 2023

View reviewed changes

refactor the whole code base to align with the new is_published logic…

aec1bf8

… and take the project ribbon off

sonatype-lift bot reviewed May 15, 2023

View reviewed changes

HesamKorki added epic waiting-for-merge Issue has been implemented, waiting to be merged and removed wip Work In Progress epic labels May 15, 2023

Fancien reviewed May 16, 2023

View reviewed changes

refactored publish method as an abstract method in coretrackedmodel a…

b89e528

…nd used it in dataset view

sonatype-lift bot reviewed May 16, 2023

View reviewed changes

nirmeen marked this pull request as ready for review May 16, 2023 13:56

neoflex reviewed May 16, 2023

View reviewed changes

added generate_elu_accession to publish in dataset model

2fcfa37

sonatype-lift bot reviewed May 16, 2023

View reviewed changes

core/models/dataset.py Show resolved Hide resolved

sonatype-lift bot reviewed May 16, 2023

View reviewed changes

core/models/dataset.py Show resolved Hide resolved

saved dataset on exposure delete to trigger reindex and renamed is_pu…

dc2a851

…blished migration and linked it to last migration on develop

sonatype-lift bot reviewed May 17, 2023

View reviewed changes

core/migrations/0034_auto_20230515_1353.py Show resolved Hide resolved

sonatype-lift bot reviewed May 17, 2023

View reviewed changes

core/migrations/0034_auto_20230515_1353.py Show resolved Hide resolved

sonatype-lift bot reviewed May 17, 2023

View reviewed changes

core/migrations/0034_auto_20230515_1353.py Show resolved Hide resolved

HesamKorki approved these changes May 17, 2023

View reviewed changes

Fancien merged commit ce6c83a into develop May 17, 2023

vildead deleted the 422-is-published-property branch July 10, 2024 09:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#422-is-published-property #423

#422-is-published-property #423

nirmeen commented May 15, 2023 •

edited

Loading

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

sonatype-lift bot May 15, 2023

Fancien May 16, 2023

nirmeen May 17, 2023

sonatype-lift bot May 16, 2023

neoflex May 16, 2023

nirmeen May 16, 2023

neoflex May 16, 2023

nirmeen May 16, 2023

nirmeen May 17, 2023

		@@ -0,0 +1,32 @@
		# Generated by Django 3.2.19 on 2023-05-15 11:53

		import core.models.utils

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		@@ -151,7 +151,9 @@ def __str__(self):
		return self.acronym or self.title or "undefined"



		@property

		@@ -3,6 +3,7 @@
		from django.contrib.auth.decorators import user_passes_test

#422-is-published-property #423

#422-is-published-property #423

Conversation

nirmeen commented May 15, 2023 • edited Loading

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 15, 2023

Choose a reason for hiding this comment

Fancien May 16, 2023

Choose a reason for hiding this comment

nirmeen May 17, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 16, 2023

Choose a reason for hiding this comment

neoflex May 16, 2023

Choose a reason for hiding this comment

nirmeen May 16, 2023

Choose a reason for hiding this comment

neoflex May 16, 2023

Choose a reason for hiding this comment

nirmeen May 16, 2023

Choose a reason for hiding this comment

nirmeen May 17, 2023

Choose a reason for hiding this comment

nirmeen commented May 15, 2023 •

edited

Loading