v1: Cut mksnapshot, update dependencies, promisify #165
Conversation
|
@malept: Sure! Do you want to just push to this branch? |
Works for me. |
BREAKING CHANGE: removes callback-based API. Use the `nodeify` module if you need this functionality.
There was a problem hiding this comment.
@felixrieseberg @MarshallOfSound somehow I managed to refactor the entire module to Promises ... on the third try. Streams are kind of tricky when you're not using helper modules.
| const stat = fs.lstatSync(filename) | ||
| const pify = require('pify') | ||
|
|
||
| const fs = pify(process.versions.electron ? require('original-fs') : require('fs')) |
There was a problem hiding this comment.
I'd much rather use fs-extra but I don't think you can override the fs module that's used, from what I could tell. I'd be happy if someone could prove me wrong, because I'd get rid of rimraf, mkdirp, and a homebrewed copyFile (which we can probably get rid of anyway, when we move to Node 8).
| const pify = require('pify') | ||
|
|
||
| const fs = pify(process.versions.electron ? require('original-fs') : require('fs')) | ||
| const glob = pify(require('glob')) |
There was a problem hiding this comment.
Not using glob-promise because I was trying to minimize the dependencies I added, and glob-promise doesn't add much for what we're doing.
malept
changed the title
| } | ||
| } | ||
| return false | ||
| return unpackDirs.some(unpackDir => dirPath.startsWith(unpackDir)) |
|
Reviewed all the commits piece by piece and I can't say I disagree with anything. LGTM! |
This PR does
fivesix things:mksnapshotand the already brokensnapshotfunctionalitystandardnew BufferwithBuffer.allocassert.equalwithassert.strictEqualnodeify.)Fixes #163
Fixes #156