Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt-electron latest version includes vulnerable mksnapshot #974

Closed
3 tasks done
jlindberg-oss opened this issue Apr 10, 2019 · 2 comments
Closed
3 tasks done

grunt-electron latest version includes vulnerable mksnapshot #974

jlindberg-oss opened this issue Apr 10, 2019 · 2 comments
Labels
invalid ❌ Not related to Electron Packager directly

Comments

@jlindberg-oss
Copy link

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

#952 updated the asar dependency of electron-packager to move off of mksnapshot, which had a high severity vulnerability in a transitive dependency: https://www.npmjs.com/advisories/777

More details at electron/asar#165

However no release of grunt-electron has been created so the latest version (9.0.1) still includes the vulnerable dependency.

I am opening this issue here per the README of grunt-electron: https://github.com/sindresorhus/grunt-electron/blob/master/readme.md

To Reproduce

npm install --save grunt-electron
npm audit
@welcome
Copy link

welcome bot commented Apr 10, 2019

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@malept malept added invalid ❌ Not related to Electron Packager directly and removed bug 🐛 labels Apr 10, 2019
@malept
Copy link
Member

malept commented Apr 10, 2019

Despite what the grunt-electron README says, this issue should be reported in the grunt-electron repository itself. electron-packager already has the dependency update, and grunt-electron just needs to be updated to electron-packager >= 13.1.0 as per the NEWS file.

@malept malept closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❌ Not related to Electron Packager directly
Projects
None yet
Development

No branches or pull requests

2 participants