Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node to >= 6 and asar to ^1.0.0 #290

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Upgrade Node to >= 6 and asar to ^1.0.0 #290

merged 3 commits into from
Feb 28, 2019

Conversation

malept
Copy link
Member

@malept malept commented Feb 20, 2019

This is in response to the changes in electron/asar#165. This module only uses extractFile, so it should be fine with zero changes other than to package.json.

@carterbs
Copy link

@MarshallOfSound wondering if this will be merged in the coming weeks. Would be great to have our audit return 0 vulnerabilities.

@malept
Copy link
Member Author

malept commented Feb 21, 2019

This is technically a vulnerability that can be ignored for this module, as electron-winstaller doesn't use any of the functionality provided by the transitive dependency in asar.

@carterbs
Copy link

This is technically a vulnerability that can be ignored for this module, as electron-winstaller doesn't use any of the functionality provided by the transitive dependency in asar.

Hey Mark. Thanks for the note. I could possibly sell that. I would so much rather not have to. :-) Thank you for submitting this PR, and for getting an update for packager pushed out so quickly.

@malept
Copy link
Member Author

malept commented Feb 21, 2019

Ugh. This module requires Node 4, and asar requires Node 6. I guess we're major version bumping. Might as well do some cleanup while we're doing that.

Brad Carter and others added 2 commits February 24, 2019 22:40
* Update fs-extra to 7.0.0 and remove obsolete fs wrappers
* Update ava and babel
* Replace bluebird with pify
* Require the correct Node version in package.json
@malept malept changed the title Upgrade asar to ^1.0.0 Upgrade Node to >= 6 and asar to ^1.0.0 Feb 25, 2019
@MarshallOfSound MarshallOfSound merged commit a113097 into master Feb 28, 2019
@MarshallOfSound MarshallOfSound deleted the asar-1.0.0 branch February 28, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants