-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] defaults plugins migration to new Event interface and plugin-api 2.0 #5227
Comments
We can automate all of the heavy work minus the actual code/spec? |
@ph +1 for automating.. |
it might be tricky to automate the addition of dependent plugins from the gemspec but the basic block
can be easily automated |
also I've seen a bit different |
Btw, all plugins should have the integration flag set if its not already there.. |
I added the list of plugins done so far for passing core specs. |
@suyograo logstash-codec-oldlogstashjson is marked as completed but I can't find the PR. |
Here's the merge plan:
|
|
@colinsurprenant updated. |
@colinsurprenant We already have v1, it was before the shutdown change, and used to target LS 1.5? |
@ph how is that possible? we only recently introduced the plugin-core-api gem recently |
@colinsurprenant Also, here is a Includes |
I am not sure we should mass update with the But this could be a good way to find which plugins are failling and change their travis.yml manually. @colinsurprenant @suyograo |
@suyograo After discussing on slack @colinsurprenant Can we move forward? |
@ph @suyograo it is still confused.
For this I suggest we simply leave the core-api-v1 branch name as-is, for legacy reasons, which anyway will not be needed anymore, and introduce branches with the plugin-api name and versions. |
@colinsurprenant @ph I am fine with naming the branch based on plugin API version. Good with |
This is a meta issue to track progress for refactoring the defaults plugins. Core plugins migration has been completed per #5170. Related #5140.
This migration recipe goals are:
Plugin Migration Recipe
create branch
feature/plugin-api-2_0
this branch should be published upstream in the
logstash-plugins
repo..travis.yml
should be updated tominimally these gems need to be added to the plugin
Gemfile
add any other plugins in the gemspec required by this plugin, for example, if
logstash-codec-plain
is a required plugin add this:modify the gemspec to bump the plugin-api version constrain to 2.0:
and finally, refactor code and specs for new Event interface
Running local specs
if you want to test locally you will have to create a symbolic link to the logstash code base with the
feature/event_interface
shared branchHelpful Scripts
@ph has added this ruby script to automate much of the initial work: https://gist.github.com/e28dddccfbe32c3985ab51d6f9b9ec41
Plugins for core specs
The text was updated successfully, but these errors were encountered: